all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] api: ceph: improve reporting of ceph OSD memory usage
Date: Wed, 16 Aug 2023 17:11:09 +0200	[thread overview]
Message-ID: <a8fc87fd-0070-b8a8-87dd-b3b96de2efe2@proxmox.com> (raw)
In-Reply-To: <ad3d7a02-c012-4394-84f4-33c28e008eeb@proxmox.com>



On 8/16/23 16:59, Aaron Lauterer wrote:
 > one small nitL: if the OSD is powered off, we now send null for the
 > meminfo. Maybe set it explicitly to 0 to not change the behavior?

ah yes, I even had it that way initially but seems like it got removed 
again when I tried to be smart and culled the line (which I changed prior):

	$memory = defined($memory) ? int($memory) : 0;


I'll send a v2 shortly




      reply	other threads:[~2023-08-16 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 14:34 Stefan Hanreich
2023-08-16 14:59 ` Aaron Lauterer
2023-08-16 15:11   ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8fc87fd-0070-b8a8-87dd-b3b96de2efe2@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal