Re: [pdm-devel] [PATCH datacenter-manager v2 1/3] lib/server: pve: add api call to get the cached version info from remotes

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.12.25 um 12:15 schrieb Dominik Csapak:
> this is useful when we e.g. want to feature gate some things in the ui.
> This way we don't have to get the whole update information for all
> remotes, and we don't have to query all nodes of the remotes for their
> versions.
> 
> Should we need it in the future, we can do the analagous api call for
> pbs too.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  lib/pdm-client/src/lib.rs    |  6 ++++++
>  server/src/api/pve/mod.rs    | 21 +++++++++++++++++++++
>  server/src/remote_updates.rs | 22 +++++++++++++++++++++-
>  3 files changed, 48 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs
> index 11bedb64..f8d6062a 100644
> --- a/lib/pdm-client/src/lib.rs
> +++ b/lib/pdm-client/src/lib.rs
> @@ -3,6 +3,7 @@
>  use std::collections::HashMap;
>  use std::time::Duration;
>  
> +use pdm_api_types::remote_updates::RemoteUpdateSummary;
>  use pdm_api_types::remotes::{RemoteType, TlsProbeOutcome};
>  use pdm_api_types::resource::{PveResource, RemoteResources, ResourceType, TopEntities};
>  use pdm_api_types::rrddata::{
> @@ -554,6 +555,11 @@ impl<T: HttpApiClient> PdmClient<T> {
>          Ok(self.0.get(&query).await?.expect_json()?.data)
>      }
>  
> +    pub async fn pve_cluster_updates(&self, remote: &str) -> Result<RemoteUpdateSummary, Error> {
> +        let url = format!("/api2/extjs/pve/remotes/{remote}/updates");

Hmm, wondering if we should expose the top-level /version API endpoint [0]
for such things, as that uses only "compiled"-in constants when returning,
so would be a bit cheaper.

I mean, this can be switched at any time, so it probably just doesn't really
matter for now..

OTOH, your approach actually might be superior, as one gets the node-specific
info for the whole remote, not just the version for the node one connects too.

[0]: https://pve.proxmox.com/pve-docs/api-viewer/index.html#/version




_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel