Re: [pdm-devel] [PATCH datacenter-manager v5 00/26] enable custom views on the UI

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 26.11.25 um 16:19 schrieb Dominik Csapak:
> With this series, users are able to add/edit/delete custom views.
> 
> NOTE: this series is based on lukas follow up series to the views[0]
> but needs the change i mentioned in [1] to completely work.
> 
> A new 'Views' menu entry is added where the CRUD ui sits, and an entry
> for each view below it.
> 
> The includes/excludes are editable from the CRUD grid, and the layout is
> editable in the view itself.
> 
> For now i opted to make the layout part of the `ViewConfig` struct, but
> as a simple json-string only, because we're not able to use the
> api-macro (for now; the rust enum features i use are currently not
> supported there). To verify it regardless, we try to deserialize
> the layout in the add/update call, so that no wrong layout can enter
> the config (via the api).
> 
> The patch 'ui: dashboard: prepare view for editint custom views'
> is adapted from my last series, but all other changes are new,
> especially the CRUD api.
> 
> There is still one part wrong, namely
> * subscriptions panels are still added by default when none is in the
>   layout itself (the plan is to move the subscription notice)
> 

Smaller things I noticed:

- when adding a view there is missing frontend validation for the name, one
  can e.g. enter "Virtual Guests" there and then only gets an error on submit.
  FWIW, we could split name and ID here (can be done any time later too though)

- as you already write, having the subscription state of all remotes summarized
  in  the top panel would be nice, and that should be probably computed in the
  backend so that it can work for views that do not have any node included.

- I get where you come from with the eye icon, but maybe use "fa-plus-square-o"
  for now to simbolize a view with it's grid-like (well flex, but for users
  without CSS knowledge that distinction probably doesn't matter) arrangement
  of cards?
  https://fontawesome.com/v4/icon/plus-square-o
  The top-level entry should also use the same icon (in the midterm ideally same
  spirit but plural).

- export/import would be nice and potentially cheap to add FWICT.

- /view/... ACL paths are not yet visible in the ACL object path selector, e.g.
  when adding a new permission.

- some generic resource stats counter might be nice and cheap.

Might need to re-check this out with a bit fresher mind, but I already did once
before and given that I saw nothing completely off for my taste after playing
around with it for half an hour I see no reason to delay this any further now,
especially given our current time horizon.

Actually: Real nice work overall with this joint effort from you and Lukas!


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel