From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v4 proxmox-backup] fix #5710: api: backup: stat known chunks on backup finish
Date: Tue, 26 Nov 2024 11:12:10 +0100 [thread overview]
Message-ID: <a6ecbba9-fbbb-4f6c-be81-2d575c4f3b93@proxmox.com> (raw)
In-Reply-To: <eb776a1b-4173-4255-8c7a-aa0778180a8f@proxmox.com>
Am 26.11.24 um 08:36 schrieb Christian Ebner:
> On 11/25/24 22:42, Thomas Lamprecht wrote:
>> please include this stuff in the actual commit message, it's nice to see as
>> point-in-time sample when reading the git log.
>> A comparison with bigger disks, say 1 TB, would be additionally great to see
>> how this scales with big disk size.
>
> Thanks for feedback!
>
> I decided to not include these in the patch directly, as the tests
> performed were limited in extend and setup, so I was unsure how
> representative they actually are.
In such cases it's fine to include them with exactly such a disclaimer.
> I will however keep this in mind for next time, as this has already been
> applied as is.
The data is out there so already good, I just have a strong preference
of having these things in the commit log too.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-26 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:46 Christian Ebner
2024-11-22 9:36 ` [pbs-devel] applied: " Fabian Grünbichler
2024-11-25 21:42 ` [pbs-devel] " Thomas Lamprecht
2024-11-26 7:36 ` Christian Ebner
2024-11-26 10:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ecbba9-fbbb-4f6c-be81-2d575c4f3b93@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.