From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/3] ui: resource tree: fix order of types
Date: Tue, 12 Nov 2024 14:23:54 +0100 [thread overview]
Message-ID: <a6da4a2d-f665-4698-b0c5-9ee80a83b8fa@proxmox.com> (raw)
In-Reply-To: <20241112114506.1970103-1-d.csapak@proxmox.com>
Am 12.11.24 um 12:45 schrieb Dominik Csapak:
> when ordering items on the same level, we often sort first by type, but
> do this via string comparison of the types.
>
> this leads to weird results if we have e.g. lxc/node/qemu mixed in one
> list, as nodes would sort in between lxc and qemu
>
> this patch solves that issue by introducing a fixed order for types, so
> we have direct control over the order when mixing types without having
> to change the type names.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/tree/ResourceTree.js | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-12 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 11:45 [pve-devel] " Dominik Csapak
2024-11-12 11:45 ` [pve-devel] [PATCH manager 2/3] ui: view selector: prepare filterfn to be more efficient Dominik Csapak
2024-11-12 13:23 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-12 11:45 ` [pve-devel] [PATCH manager 3/3] ui: resource tree: show nodes/storages in pool/tag view by default Dominik Csapak
2024-11-12 13:38 ` Thomas Lamprecht
2024-11-12 15:04 ` Dominik Csapak
2024-11-12 13:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6da4a2d-f665-4698-b0c5-9ee80a83b8fa@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal