From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/12] clippy fixes
Date: Tue, 6 Apr 2021 09:42:13 +0200 [thread overview]
Message-ID: <a66eb279-d3ee-5e76-b511-a39d4509441a@proxmox.com> (raw)
In-Reply-To: <147179381.645.1617694207013@webmail.proxmox.com>
On 4/6/21 9:30 AM, Dietmar Maurer wrote:
> IO am currently rewriting large parts of the tape driver, so
> this is a bad time for clippy fixes...
nvm then, it was just tedious to check my own code with clippy with
those warnings/errors in place. i'll happily send another round
of these later when you're done
>
>> On 04/06/2021 8:27 AM Dominik Csapak <d.csapak@proxmox.com> wrote:
>>
>>
>> various clippy fixes all over the place
>> if the separation is not ok, i can send them ofc separated
>> differently
>>
>> (they were not too many of the same type to group by warning,
>> and too spread out to group by file, so i settled for some middle
>> ground)
>>
>> Dominik Csapak (12):
>> api2/tape: clippy fixes
>> tape/changer: clippy fixes
>> tape/drive: clippy fixes
>> tape/media_*: clippy fixes
>> tape/pool_writer: clippy fixes
>> backup: clippy fixes
>> pxar: clippy fix `or_fun_call`
>> bin: clippy fixes
>> tape/*: clippy fixes
>> tools: clippy fixes
>> config/tape_encryption_keys: clippy fixes
>> server/worker_task: clippy fix
>>
>> src/api2/config/tape_backup_job.rs | 1 +
>> src/api2/tape/backup.rs | 2 +-
>> src/api2/tape/media.rs | 42 ++++++++++----------
>> src/api2/tape/restore.rs | 12 +++---
>> src/backup/key_derivation.rs | 6 +--
>> src/backup/manifest.rs | 1 +
>> src/bin/docgen.rs | 2 +-
>> src/bin/pmt.rs | 2 +-
>> src/bin/pmtx.rs | 2 +-
>> src/config/tape_encryption_keys.rs | 8 ++--
>> src/pxar/extract.rs | 4 +-
>> src/server/worker_task.rs | 2 +-
>> src/tape/changer/online_status_map.rs | 4 +-
>> src/tape/changer/sg_pt_changer.rs | 2 +-
>> src/tape/drive/linux_tape.rs | 2 +-
>> src/tape/drive/mam.rs | 12 +++---
>> src/tape/drive/mod.rs | 4 +-
>> src/tape/drive/virtual_tape.rs | 2 +-
>> src/tape/file_formats/multi_volume_writer.rs | 2 +-
>> src/tape/inventory.rs | 2 +-
>> src/tape/media_catalog.rs | 10 +++--
>> src/tape/media_pool.rs | 16 +++-----
>> src/tape/media_set.rs | 4 ++
>> src/tape/pool_writer/catalog_set.rs | 1 +
>> src/tape/pool_writer/mod.rs | 4 +-
>> src/tape/pool_writer/new_chunks_iterator.rs | 4 +-
>> src/tools/fs.rs | 3 ++
>> src/tools/sgutils2.rs | 18 ++++-----
>> 28 files changed, 93 insertions(+), 81 deletions(-)
>>
>> --
>> 2.20.1
>>
>>
>>
>> _______________________________________________
>> pbs-devel mailing list
>> pbs-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2021-04-06 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 7:30 Dietmar Maurer
2021-04-06 7:42 ` Dominik Csapak [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-06 6:27 Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a66eb279-d3ee-5e76-b511-a39d4509441a@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.