From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH 0/2] Fix systemd ordering for qmeventd.service
Date: Thu, 12 Nov 2020 17:07:16 +0100 [thread overview]
Message-ID: <a65a340f-0fb1-61dd-3ea7-0c58abc1e67e@proxmox.com> (raw)
In-Reply-To: <20201112154400.28457-1-s.reiter@proxmox.com>
On 12.11.20 16:43, Stefan Reiter wrote:
> Reported in the forum:
> https://forum.proxmox.com/threads/shutdown-reboot-error-nodes.78906/
>
> Since qmeventd is now responsible for stopping QEMU instances after they shut
> down, it needs to keep running for as long as there are guests, otherwise the
> host will hang waiting for guests to exit.
>
> Fix this in pve-guests.service for regular VMs and pve-ha-lrm.service for HA.
>
> I'm not too familiar with systemd services, but I figured the After is enough,
> since Wants implies that qmeventd must be running for the services to work,
> which is not true, the VMs will work fine, as long as the user takes care of
> cleanup themselves somehow or doesn't use shutdown (and by default
> qmeventd.service is enabled anyway). But easy enough to change if that's wrong.
>
> Not sure how to handle version bumping, I'd assume qemu-server needs a depends
> on new pve-manager and pve-ha-manager to ensure non-broken behaviour?
>
>
> manager: Stefan Reiter (1):
> stop qmeventd.service after pve-guests.service
>
> services/pve-guests.service | 1 +
> 1 file changed, 1 insertion(+)
>
> ha-manager: Stefan Reiter (1):
> stop qmeventd.service after pve-ha-lrm.service
>
> debian/pve-ha-lrm.service | 1 +
> 1 file changed, 1 insertion(+)
>
applied the reverse to qemu-server, thanks!
prev parent reply other threads:[~2020-11-12 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 15:43 [pve-devel] " Stefan Reiter
2020-11-12 15:43 ` [pve-devel] [PATCH manager 1/2] stop qmeventd.service after pve-guests.service Stefan Reiter
2020-11-12 15:44 ` [pve-devel] [PATCH ha-manager 2/2] stop qmeventd.service after pve-ha-lrm.service Stefan Reiter
2020-11-12 16:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a65a340f-0fb1-61dd-3ea7-0c58abc1e67e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal