all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 5/6] ui: add verify-schedule field to edit datastore form
Date: Fri, 18 Sep 2020 15:26:49 +0200	[thread overview]
Message-ID: <a60c2a02-318a-0eaf-e08c-08155ab3b085@proxmox.com> (raw)
In-Reply-To: <20200918090052.79979-6-h.laimer@proxmox.com>

On 9/18/20 11:00 AM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  www/config/DataStoreConfig.js | 5 +++--
>  www/window/DataStoreEdit.js   | 9 +++++++++
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/www/config/DataStoreConfig.js b/www/config/DataStoreConfig.js
> index 54d7a505..685d3d5f 100644
> --- a/www/config/DataStoreConfig.js
> +++ b/www/config/DataStoreConfig.js
> @@ -11,8 +11,9 @@ Ext.define('pbs-datastore-list', {
>  Ext.define('pbs-data-store-config', {
>      extend: 'Ext.data.Model',
>      fields: [
> -	'name', 'path', 'comment', 'gc-schedule', 'prune-schedule', 'keep-last',
> -	'keep-hourly', 'keep-daily', 'keep-weekly', 'keep-monthly', 'keep-yearly',
> +	'name', 'path', 'comment', 'gc-schedule', 'prune-schedule',
> +	'verify-schedule', 'keep-last', 'keep-hourly', 'keep-daily',
> +	'keep-weekly', 'keep-monthly', 'keep-yearly',
>      ],
>      proxy: {
>          type: 'proxmox',
> diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js
> index adb857ab..926a8a19 100644
> --- a/www/window/DataStoreEdit.js
> +++ b/www/window/DataStoreEdit.js
> @@ -71,6 +71,15 @@ Ext.define('PBS.DataStoreEdit', {
>  			    deleteEmpty: '{!isCreate}',
>  			},
>  		    },
> +		{
> +			xtype: 'pbsCalendarEvent',
> +			name: 'verify-schedule',
> +			fieldLabel: gettext("Verify Schedule"),
> +			emptyText: gettext('none'),
> +			cbind: {
> +			    deleteEmpty: '{!isCreate}',
> +			},
> +		    },
>  		],
>  		columnB: [
>  		    {
> 

just as a note, respective column is missing from the datastore configuration
grid. But, see also my and Dominik's other mail about the different, more
flexible and less crowded approach to list/manage schedules.




  reply	other threads:[~2020-09-18 13:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  9:00 [pbs-devel] [PATCH v2 proxmox-backup 0/6] add scheduled verification of datastore Hannes Laimer
2020-09-18  9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 1/6] api2: add VERIFY_SCHEDULE_SCHEMA Hannes Laimer
2020-09-18  9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 2/6] add verify_schedule field to DataStoreConfig Hannes Laimer
2020-09-18  9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 3/6] api2: add optional verify-schdule field to create/update datastore endpoint Hannes Laimer
2020-09-18  9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 4/6] api2: make verify_schedule deletable Hannes Laimer
2020-09-18  9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 5/6] ui: add verify-schedule field to edit datastore form Hannes Laimer
2020-09-18 13:26   ` Thomas Lamprecht [this message]
2020-09-18  9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 6/6] add verification scheduling to proxmox-backup-proxy Hannes Laimer
2020-09-18 10:10 ` [pbs-devel] [PATCH v2 proxmox-backup 0/6] add scheduled verification of datastore Dominik Csapak
2020-09-18 13:23   ` Thomas Lamprecht
2020-09-18 10:13 ` [pbs-devel] applied: " Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a60c2a02-318a-0eaf-e08c-08155ab3b085@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal