all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>,
	Moayad Almalat <m.almalat@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v2 manager] fix #3037: include the split_list to shell_qoute
Date: Wed, 25 Jan 2023 09:59:20 +0100	[thread overview]
Message-ID: <a5e3822d-549b-7b15-547b-58ff8f876554@proxmox.com> (raw)
In-Reply-To: <20230125083854.g5o2itt5etcgig37@casey.proxmox.com>

Am 25/01/2023 um 09:38 schrieb Wolfgang Bumiller:
> applied
> 
> Though the whole commit message is actually the change log to v1 of the
> patch and should not have mentioned the `split_list` part at all, only
> what it actually does and the change list should go below the `---`,
> please separate these things in the future.
> 

but you also applied it as is? I.e., outdated and far from helpful for
extracting and actual useful d/changelog entry.

please either amend commit messages on applying, if they're wrong, outdated,
..., otherwise reject the patch on that ground.




  reply	other threads:[~2023-01-25  8:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23  9:52 [pve-devel] " Moayad Almalat
2023-01-25  8:38 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-25  8:59   ` Thomas Lamprecht [this message]
2023-01-25  9:30     ` Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5e3822d-549b-7b15-547b-58ff8f876554@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.almalat@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal