all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 5/5] ui: remote edit: add 'web-url' options to the edit panel
Date: Wed, 15 Jan 2025 16:27:09 +0100	[thread overview]
Message-ID: <a59c6b3b-ad10-4d16-a62b-b9d44cf5b2ed@proxmox.com> (raw)
In-Reply-To: <20250110102142.1212874-7-d.csapak@proxmox.com>

Am 10.01.25 um 11:21 schrieb Dominik Csapak:
> so users can modify it.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/remotes/edit_remote.rs | 59 ++++++++++++++++++++++++++++++-----
>  1 file changed, 52 insertions(+), 7 deletions(-)
> 

> @@ -97,6 +117,31 @@ fn edit_remote_input_panel(_form_ctx: &FormContext, remote_id: &str) -> Html {
>                  .input_type(InputType::Password)
>                  .required(false),
>          )
> +        .with_field(
> +            tr!("Web Base URL"),
> +            Field::new()
> +                .name("_web-url_base-url")
> +                .placeholder(tr!("Automatically generate from first connection.")),

"Generated from first endpoint."

As one might not be sure what first connection means, e.g. could be "first query
remote connection").

> +        )
> +        .with_field(
> +            tr!("per Node URL template"),
> +            Field::new()
> +                .name("_web-url_per-node-template")
> +                .placeholder(tr!("Same as Web Base URL.")),
> +        )

This is rather confusing.. Why you went this route without adding any reasoning
at all? My take from the last discussion we had last Thursday was a single option
with potentially a UI (only) switch for UX; which I would have done with a radio
group and still a single text field to avoid letting user entering two things
where the first one will never be used if the second is entered.

In any way, _please_ lets actually review things and not just blindly apply
them...

> +        .with_custom_child(
> +            Row::new()
> +                .key("hint-text")
> +                .gap(2)
> +                .with_child(Container::new().with_child(tr!(
> +                    "Possible template values for 'per Node URL template' are:"
> +                )))
> +                .with_child(
> +                    Container::new()
> +                        .style("font-family", "monospace")
> +                        .with_child("{{nodename}}"),
> +                ),
> +        )
>          .with_custom_child(
>              Container::new()
>                  .key("nodes-title")



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-01-15 15:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 10:21 [pdm-devel] [PATCH yew-comp/datacenter-manager] make ui url generation configurable Dominik Csapak
2025-01-10 10:21 ` [pdm-devel] [PATCH yew-comp 1/1] form: add helpers for property strings Dominik Csapak
2025-01-10 10:21 ` [pdm-devel] [PATCH datacenter-manager 1/5] server: add an optional 'web-url' property for remotes Dominik Csapak
2025-01-15 15:12   ` Thomas Lamprecht
2025-01-16  8:04     ` Dominik Csapak
2025-01-23  8:48       ` Thomas Lamprecht
2025-01-23 13:31         ` Dominik Csapak
2025-01-10 10:21 ` [pdm-devel] [PATCH datacenter-manager 2/5] ui: remote edit: add missing key for displayfield Dominik Csapak
2025-01-10 10:21 ` [pdm-devel] [PATCH datacenter-manager 3/5] ui: remote edit: rename 'Nodes' to 'Endpoints' Dominik Csapak
2025-01-10 10:21 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: generate URLs with the option 'web-url' property Dominik Csapak
2025-01-10 10:21 ` [pdm-devel] [PATCH datacenter-manager 5/5] ui: remote edit: add 'web-url' options to the edit panel Dominik Csapak
2025-01-15 15:27   ` Thomas Lamprecht [this message]
2025-01-15 17:40     ` Dietmar Maurer
2025-01-13 14:33 ` [pdm-devel] [PATCH yew-comp/datacenter-manager] make ui url generation configurable Dominik Csapak
2025-01-15 13:12 ` [pdm-devel] applied: " Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a59c6b3b-ad10-4d16-a62b-b9d44cf5b2ed@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal