all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Philipp Hufnagl <p.hufnagl@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks
Date: Thu, 16 Nov 2023 12:04:17 +0100	[thread overview]
Message-ID: <a57d2912-6781-403f-8e14-3b0e4b2995c5@proxmox.com> (raw)
In-Reply-To: <55edb79e-7276-4612-9961-c297e15bdb33@proxmox.com>

Am 16.11.23 um 11:45 schrieb Philipp Hufnagl:
> 
> I was trying to order the commits in a way that, while they are
> changing the code, the should not impact the behavior of the program.
> It should be possible to apply all previous commits without modifying
> the behavior.
> 
> If it is easier or maintainers, I can attempt to implement the fix
> first, then the clean up after

IMHO, preparatory patches should be required for the fix or make it
easier to get to the fix. If it's an optimization that requires a few
changes, it's better done as a follow-up. Of course there are exceptions
to this. From my side, you don't have to go out of your way and re-do it
for this series.




      reply	other threads:[~2023-11-16 11:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 16:00 [pve-devel] [PATCH storage v2 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace Philipp Hufnagl
2023-11-15 16:00 ` [pve-devel] [PATCH storage v2 1/4] pbs: Move pbs_api_connect earlyer in the code Philipp Hufnagl
2023-11-15 16:00 ` [pve-devel] [PATCH storage v2 2/4] pbs: Make it possible to reuse PBS connection for datastore API call Philipp Hufnagl
2023-11-16  9:40   ` Christian Ebner
2023-11-15 16:00 ` [pve-devel] [PATCH storage v2 3/4] pbs: Extraxt check_datastore_exists from activate_storage Philipp Hufnagl
2023-11-16  9:43   ` Christian Ebner
2023-11-15 16:00 ` [pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks Philipp Hufnagl
2023-11-16  9:45   ` Christian Ebner
2023-11-16  9:57   ` Fiona Ebner
2023-11-16 10:45     ` Philipp Hufnagl
2023-11-16 11:04       ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a57d2912-6781-403f-8e14-3b0e4b2995c5@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=p.hufnagl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal