From: "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option.
Date: Tue, 5 Oct 2021 12:13:03 +0000 [thread overview]
Message-ID: <a4e9b0c5c8a25dbd1ba1be9f32535bcb0206a4bb.camel@groupe-cyllene.com> (raw)
In-Reply-To: <1633432128.w00qu8ioxe.astroid@nora.none>
Le mardi 05 octobre 2021 à 13:12 +0200, Fabian Grünbichler a écrit :
> shouldn't this be the other way round? check keys which are
> different,
> and have a list of hotpluggable ones, skip if any others are
> different?
>
> that way if we add another property to the agent it's fail-safe
> (defaults to not being hotpluggable) until it is added to the
> explicit
> list
yes, sure. I'll rework the patch and send a v3 tomorrow.
thanks for the review !
prev parent reply other threads:[~2021-10-05 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 9:46 Alexandre Derumier
2021-10-05 11:12 ` Fabian Grünbichler
2021-10-05 12:13 ` DERUMIER, Alexandre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e9b0c5c8a25dbd1ba1be9f32535bcb0206a4bb.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal