From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v2] fix #3588: helper: consider NIC count for config-specific timeout
Date: Mon, 25 Nov 2024 16:15:43 +0100 [thread overview]
Message-ID: <a48aabb7-1b2c-478b-80b6-6ab871cd92fa@proxmox.com> (raw)
In-Reply-To: <20241121151335.130711-1-h.laimer@proxmox.com>
Am 21.11.24 um 16:13 schrieb Hannes Laimer:
> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
> index 0afb6317..1888487e 100644
> --- a/PVE/QemuServer/Helpers.pm
> +++ b/PVE/QemuServer/Helpers.pm
> @@ -167,6 +167,15 @@ sub config_aware_timeout {
> $timeout = 150;
> }
>
> + # Some testing showed that adding a NIC increased the start time by ~450ms
> + # consistently across different NIC models, options and already existing
> + # number of NICs.
> + # So 10x that to account for any potential system differences seemed
> + # reasonable. User reports with real-life values (20+: ~50s, 25: 45s, 17: 42s)
> + # also make this seem a good value.
> + my $nic_count = grep { /^net\d{1,2}/ } keys %{$config};
I'd use \d+ like in other places.
> + $timeout += scalar ($nic_count * 5);
I meant using scalar() around the grep, not here ;)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-25 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 15:13 Hannes Laimer
2024-11-25 15:15 ` Fiona Ebner [this message]
2024-11-26 9:14 ` Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48aabb7-1b2c-478b-80b6-6ab871cd92fa@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal