Re: [PATCH proxmox-ve-rs 2/9] frr: implement routemap match/set statements via adjacent tagging

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-03-25 10:41, Stefan Hanreich wrote:
> Previously the types used a mix of adjacent / internal tagging and a
> nesting of types to represent match and set statements. This has been
> simplified by utilizing adjacent tagging on the set / match statements
> and using the exact FRR configuration key as the tag. This way a
> single enum can be used to represent match / set statements and all
> variants can be rendered the same by simply printing the keys /
> values.
> 
> This commit also adds a lot of new match / set statements that were
> previously not supported. The crate supports now almost all match /
> set statements that FRR supports - with only a few having been
> omitted. Most notably it is not possible to match on community lists,
> support for those is planned in a future patch series.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---

[..]

> diff --git a/proxmox-frr/src/ser/route_map.rs b/proxmox-frr/src/ser/route_map.rs
> index d12ae05..22807f1 100644
> --- a/proxmox-frr/src/ser/route_map.rs
> +++ b/proxmox-frr/src/ser/route_map.rs
> @@ -1,6 +1,11 @@
> +use core::net::{Ipv4Addr, Ipv6Addr};
>  use std::net::IpAddr;
>  
>  use proxmox_network_types::ip_address::Cidr;
> +use proxmox_sdn_types::{
> +    bgp::{EvpnRouteType, SetMetricValue, SetTagValue},
> +    IntegerWithSign, Vni,
> +};
>  use serde::{Deserialize, Serialize};
>  
>  /// The action for a [`AccessListRule`].
> @@ -45,6 +50,12 @@ impl AccessListName {
>      }
>  }
>  
> +impl PrefixListName {
> +    pub fn new(name: String) -> PrefixListName {
> +        PrefixListName(name)
> +    }
> +}

the same `impl` block already exists 10 lines above this one :)

[..]