all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] API: ceph: fix typo in permissions
@ 2023-01-13 10:56 Matthias Heiserer
  2023-01-13 11:40 ` [pve-devel] applied: " Wolfgang Bumiller
  2023-01-13 12:17 ` [pve-devel] " Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: Matthias Heiserer @ 2023-01-13 10:56 UTC (permalink / raw)
  To: pve-devel

With Sys.Audit being spelled wrong, this call always failed

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 PVE/API2/Ceph.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 55220324..3a73872d 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -652,7 +652,7 @@ __PACKAGE__->register_method ({
     proxyto => 'node',
     protected => 1,
     permissions => {
-	check => ['perm', '/', [ 'Sys.audit' ]],
+	check => ['perm', '/', [ 'Sys.Audit' ]],
     },
     parameters => {
 	additionalProperties => 0,
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [PATCH manager] API: ceph: fix typo in permissions
  2023-01-13 10:56 [pve-devel] [PATCH manager] API: ceph: fix typo in permissions Matthias Heiserer
@ 2023-01-13 11:40 ` Wolfgang Bumiller
  2023-01-13 12:17 ` [pve-devel] " Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Bumiller @ 2023-01-13 11:40 UTC (permalink / raw)
  To: Matthias Heiserer; +Cc: pve-devel

applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH manager] API: ceph: fix typo in permissions
  2023-01-13 10:56 [pve-devel] [PATCH manager] API: ceph: fix typo in permissions Matthias Heiserer
  2023-01-13 11:40 ` [pve-devel] applied: " Wolfgang Bumiller
@ 2023-01-13 12:17 ` Thomas Lamprecht
  2023-01-13 12:21   ` Matthias Heiserer
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2023-01-13 12:17 UTC (permalink / raw)
  To: Proxmox VE development discussion, Matthias Heiserer

Am 13/01/2023 um 11:56 schrieb Matthias Heiserer:
> With Sys.Audit being spelled wrong, this call always failed

for non-root you mean?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH manager] API: ceph: fix typo in permissions
  2023-01-13 12:17 ` [pve-devel] " Thomas Lamprecht
@ 2023-01-13 12:21   ` Matthias Heiserer
  0 siblings, 0 replies; 4+ messages in thread
From: Matthias Heiserer @ 2023-01-13 12:21 UTC (permalink / raw)
  To: Thomas Lamprecht, Proxmox VE development discussion

On 13.01.2023 13:17, Thomas Lamprecht wrote:
> Am 13/01/2023 um 11:56 schrieb Matthias Heiserer:
>> With Sys.Audit being spelled wrong, this call always failed
> 
> for non-root you mean?
Yes, exactly. Sorry, should have been clearer, I considered that as implied.
I don't think we check any permissions anywhere if the root account is 
used, do we?




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-13 12:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 10:56 [pve-devel] [PATCH manager] API: ceph: fix typo in permissions Matthias Heiserer
2023-01-13 11:40 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-13 12:17 ` [pve-devel] " Thomas Lamprecht
2023-01-13 12:21   ` Matthias Heiserer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal