all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 manager 0/4] BackupView as TreePanel
Date: Thu, 7 Apr 2022 08:57:09 +0200	[thread overview]
Message-ID: <a17ca131-8a93-9f77-2bce-d4d6dd3e2356@proxmox.com> (raw)
In-Reply-To: <f9b84886-a91d-184d-4c4c-ba28f8725551@proxmox.com>

On 07.04.22 08:31, Fabian Ebner wrote:
>>> I feel like we should always filter by backup type in the guest view
>>> like is done currently. Otherwise, there is the possibility to try and
>>> restore e.g. an LXC backup over an existing VM. That probably isn't a
>>> common use case, and it just leads to an error.
>>>
>> Yeah that's a must do IMO.
> I might've made it sound worse than it is, by not being specific. By
> default, the type *is* filtered. It's just that the checkbox now is
> "filter VMID+type" vs. previously, "filter VMID" with type filtering
> always active. As turning off that checkbox is a relatively uncommon use
> case to begin with, I didn't consider it a must.

I still do consider it a must. The checkbox is always shown and easily
accessible, I see no reason to label using it as edge-case and showing backup
files that cannot work can only confuse users and just isn't hard to fix.




      reply	other threads:[~2022-04-07  6:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 13:02 Matthias Heiserer
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 1/4] ui: Utils: Helpers for backup type and icon Matthias Heiserer
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 2/4] ui: storage: Rewrite backup content view as TreePanel Matthias Heiserer
2022-04-06 11:25   ` Fabian Ebner
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 3/4] ui: delete BackupView and replace it with the new Tree BackupView Matthias Heiserer
2022-04-04 13:02 ` [pve-devel] [PATCH v4 manager 4/4] ui: content view: remove dead code Matthias Heiserer
2022-04-06 11:26 ` [pve-devel] [PATCH v4 manager 0/4] BackupView as TreePanel Fabian Ebner
2022-04-06 15:40   ` Thomas Lamprecht
2022-04-07  6:31     ` Fabian Ebner
2022-04-07  6:57       ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a17ca131-8a93-9f77-2bce-d4d6dd3e2356@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal