From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH docs 00/10] docs (mostly) spelling update
Date: Wed, 9 Nov 2022 15:51:10 +0100 [thread overview]
Message-ID: <a0706be0-7c77-c117-f389-e12863544617@proxmox.com> (raw)
In-Reply-To: <20221109115828.137770-1-m.heiserer@proxmox.com>
Am 09/11/2022 um 12:58 schrieb Matthias Heiserer:
> These are mostly about the first chapters, I'll try to look through the later ones aswell.
> Many small patches, feel free to squash them, but I figured it's easier that way when the inevitable
> discussions about proper spelling arise :)
>
>
> Matthias Heiserer (10):
> consistently use 'web interface' (two words)
> remove misplaced comma
> consistently capitalize Ceph
> add note that secure boot needs to be disabled for host installation
> UPDATE IMAGE IN DOCSgit diff pve-installation.adocgit diff
> pve-installation.adoc! Installation options were moved into advanced
> folder, update docs to reflect that.
> add missing comma in if sentences
> rephrase when root password is set to make it clear that when logging
> it, it is already set
> add missing letter
> it's -> its because it isn't 'it is'
> update link to debian handbook. current one is 404
>
> certificate-management.adoc | 2 +-
> hyper-converged-infrastructure.adoc | 6 +++---
> pve-installation.adoc | 18 +++++++++---------
> pve-storage-pbs.adoc | 2 +-
> pve-storage-rbd.adoc | 4 ++--
> pveceph.adoc | 6 +++---
> sysadmin.adoc | 4 ++--
> 7 files changed, 21 insertions(+), 21 deletions(-)
>
applied series, thanks!
Note that I squashed two patches and reworded a few commit messages
slightly. Most of how you separated the series was pretty good (e.g., some
tree wide change for consistent Ceph spelling makes sense in one patch) but
I think in general you might want to have simple, obvious typo fixes (i.e.,
no big rewordings) from the same chapter squashed into a single patch and
prefix the commit subject with the chapter/topic (like "installation:" or
"ceph:") but at least squashing is really quickly done from my side (and
always simpler than splitting up again), so I didn't mind about how you did
the separation, just noting that I don't expected/want every single specific
typo in its own patch.
prev parent reply other threads:[~2022-11-09 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 11:58 [pve-devel] " Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 01/10] consistently use 'web interface' (two words) Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 02/10] remove misplaced comma Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 03/10] consistently capitalize Ceph Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 04/10] add note that secure boot needs to be disabled for host installation Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 05/10] move installation options to advanced folder Matthias Heiserer
2022-11-09 14:46 ` Thomas Lamprecht
2022-11-09 11:58 ` [pve-devel] [PATCH docs 06/10] add missing comma in if sentences Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 07/10] rephrase when root password is set to make it clear that when logging it, it is already set Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 08/10] add missing letter Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 09/10] it's -> its because it isn't 'it is' Matthias Heiserer
2022-11-09 11:58 ` [pve-devel] [PATCH docs 10/10] update link to debian handbook. current one is 404 Matthias Heiserer
2022-11-09 14:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0706be0-7c77-c117-f389-e12863544617@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal