* [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
@ 2022-07-19 11:24 Oguz Bektas
2022-07-19 11:52 ` Fabian Grünbichler
0 siblings, 1 reply; 5+ messages in thread
From: Oguz Bektas @ 2022-07-19 11:24 UTC (permalink / raw)
To: pve-devel
"both" option is deprecated, this gets rid of the warning in the journal
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
src/PVE/LXC/Setup/Base.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
index 8580bf0..cc12914 100644
--- a/src/PVE/LXC/Setup/Base.pm
+++ b/src/PVE/LXC/Setup/Base.pm
@@ -261,7 +261,7 @@ DATA
my ($has_ipv4, $has_ipv6);
# DHCP bitflags:
- my @DHCPMODES = ('no', 'v4', 'v6', 'both');
+ my @DHCPMODES = ('no', 'v4', 'v6', 'yes');
my ($NONE, $DHCP4, $DHCP6, $BOTH) = (0, 1, 2, 3);
my $dhcp = $NONE;
my $accept_ra = 'false';
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
2022-07-19 11:24 [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config Oguz Bektas
@ 2022-07-19 11:52 ` Fabian Grünbichler
2022-07-19 11:54 ` Oguz Bektas
0 siblings, 1 reply; 5+ messages in thread
From: Fabian Grünbichler @ 2022-07-19 11:52 UTC (permalink / raw)
To: Proxmox VE development discussion
On July 19, 2022 1:24 pm, Oguz Bektas wrote:
> "both" option is deprecated, this gets rid of the warning in the journal
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
some notion which templates you tested this with, when the deprecation
happened in systemd, whether we need a fallback to 'both' for older
versions, etc.pp. would be nice to have..
AFAICT the deprecation was in systemd v219, so should probably be okay
to switch unconditionally..
> ---
> src/PVE/LXC/Setup/Base.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> index 8580bf0..cc12914 100644
> --- a/src/PVE/LXC/Setup/Base.pm
> +++ b/src/PVE/LXC/Setup/Base.pm
> @@ -261,7 +261,7 @@ DATA
> my ($has_ipv4, $has_ipv6);
>
> # DHCP bitflags:
> - my @DHCPMODES = ('no', 'v4', 'v6', 'both');
> + my @DHCPMODES = ('no', 'v4', 'v6', 'yes');
> my ($NONE, $DHCP4, $DHCP6, $BOTH) = (0, 1, 2, 3);
> my $dhcp = $NONE;
> my $accept_ra = 'false';
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
2022-07-19 11:52 ` Fabian Grünbichler
@ 2022-07-19 11:54 ` Oguz Bektas
2022-07-22 12:50 ` [pve-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 5+ messages in thread
From: Oguz Bektas @ 2022-07-19 11:54 UTC (permalink / raw)
To: Proxmox VE development discussion
On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote:
> On July 19, 2022 1:24 pm, Oguz Bektas wrote:
> > "both" option is deprecated, this gets rid of the warning in the journal
> >
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
>
> some notion which templates you tested this with, when the deprecation
> happened in systemd, whether we need a fallback to 'both' for older
> versions, etc.pp. would be nice to have..
>
> AFAICT the deprecation was in systemd v219, so should probably be okay
> to switch unconditionally..
yes, all our current templates are using the newer systemd versions, so
no need for a fallback IMO.
i tested it with:
* arch
* fedora 35 and 36
* ubuntu 20 and 22
templates, it got rid of the warning in all of them.
>
> > ---
> > src/PVE/LXC/Setup/Base.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> > index 8580bf0..cc12914 100644
> > --- a/src/PVE/LXC/Setup/Base.pm
> > +++ b/src/PVE/LXC/Setup/Base.pm
> > @@ -261,7 +261,7 @@ DATA
> > my ($has_ipv4, $has_ipv6);
> >
> > # DHCP bitflags:
> > - my @DHCPMODES = ('no', 'v4', 'v6', 'both');
> > + my @DHCPMODES = ('no', 'v4', 'v6', 'yes');
> > my ($NONE, $DHCP4, $DHCP6, $BOTH) = (0, 1, 2, 3);
> > my $dhcp = $NONE;
> > my $accept_ra = 'false';
> > --
> > 2.30.2
> >
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> >
> >
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [pve-devel] applied: [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
2022-07-19 11:54 ` Oguz Bektas
@ 2022-07-22 12:50 ` Wolfgang Bumiller
2022-07-25 8:25 ` Thomas Lamprecht
0 siblings, 1 reply; 5+ messages in thread
From: Wolfgang Bumiller @ 2022-07-22 12:50 UTC (permalink / raw)
To: Oguz Bektas, Proxmox VE development discussion
On Tue, Jul 19, 2022 at 01:54:50PM +0200, Oguz Bektas wrote:
> On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote:
> > On July 19, 2022 1:24 pm, Oguz Bektas wrote:
> > > "both" option is deprecated, this gets rid of the warning in the journal
> > >
> > > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> >
> > some notion which templates you tested this with, when the deprecation
> > happened in systemd, whether we need a fallback to 'both' for older
> > versions, etc.pp. would be nice to have..
> >
> > AFAICT the deprecation was in systemd v219, so should probably be okay
> > to switch unconditionally..
>
> yes, all our current templates are using the newer systemd versions, so
> no need for a fallback IMO.
>
> i tested it with:
> * arch
> * fedora 35 and 36
> * ubuntu 20 and 22
> templates, it got rid of the warning in all of them.
Introduced in 2015 is old enough. Anybody using a container which
actually uses systemd-networkd *and* is that old will just have to
enable dhcp manually...
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] applied: [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
2022-07-22 12:50 ` [pve-devel] applied: " Wolfgang Bumiller
@ 2022-07-25 8:25 ` Thomas Lamprecht
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2022-07-25 8:25 UTC (permalink / raw)
To: Proxmox VE development discussion, Wolfgang Bumiller, Oguz Bektas
Am 22/07/2022 um 14:50 schrieb Wolfgang Bumiller:
> On Tue, Jul 19, 2022 at 01:54:50PM +0200, Oguz Bektas wrote:
>> On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote:
>>> On July 19, 2022 1:24 pm, Oguz Bektas wrote:
>>>> "both" option is deprecated, this gets rid of the warning in the journal
>>>>
>>>> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
>>>
>>> some notion which templates you tested this with, when the deprecation
>>> happened in systemd, whether we need a fallback to 'both' for older
>>> versions, etc.pp. would be nice to have..
>>>
>>> AFAICT the deprecation was in systemd v219, so should probably be okay
>>> to switch unconditionally..
>>
>> yes, all our current templates are using the newer systemd versions, so
>> no need for a fallback IMO.
>>
>> i tested it with:
>> * arch
>> * fedora 35 and 36
>> * ubuntu 20 and 22
>> templates, it got rid of the warning in all of them.
>
> Introduced in 2015 is old enough. Anybody using a container which
> actually uses systemd-networkd *and* is that old will just have to
> enable dhcp manually...
>
> Applied.
Why not use the already available get_systemd_version helper though?
If it wasn't available I could relate to why one wouldn't like to bother with
adding one for this specific situation, but we already got it, so adding an
automatic fallback would be for free.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-25 8:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 11:24 [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config Oguz Bektas
2022-07-19 11:52 ` Fabian Grünbichler
2022-07-19 11:54 ` Oguz Bektas
2022-07-22 12:50 ` [pve-devel] applied: " Wolfgang Bumiller
2022-07-25 8:25 ` Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.