From: Oguz Bektas <o.bektas@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
Date: Tue, 19 Jul 2022 13:54:50 +0200 [thread overview]
Message-ID: <YtabimEy5PeG09tP@gaia> (raw)
In-Reply-To: <1658231483.00qrznxz22.astroid@nora.none>
On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote:
> On July 19, 2022 1:24 pm, Oguz Bektas wrote:
> > "both" option is deprecated, this gets rid of the warning in the journal
> >
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
>
> some notion which templates you tested this with, when the deprecation
> happened in systemd, whether we need a fallback to 'both' for older
> versions, etc.pp. would be nice to have..
>
> AFAICT the deprecation was in systemd v219, so should probably be okay
> to switch unconditionally..
yes, all our current templates are using the newer systemd versions, so
no need for a fallback IMO.
i tested it with:
* arch
* fedora 35 and 36
* ubuntu 20 and 22
templates, it got rid of the warning in all of them.
>
> > ---
> > src/PVE/LXC/Setup/Base.pm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
> > index 8580bf0..cc12914 100644
> > --- a/src/PVE/LXC/Setup/Base.pm
> > +++ b/src/PVE/LXC/Setup/Base.pm
> > @@ -261,7 +261,7 @@ DATA
> > my ($has_ipv4, $has_ipv6);
> >
> > # DHCP bitflags:
> > - my @DHCPMODES = ('no', 'v4', 'v6', 'both');
> > + my @DHCPMODES = ('no', 'v4', 'v6', 'yes');
> > my ($NONE, $DHCP4, $DHCP6, $BOTH) = (0, 1, 2, 3);
> > my $dhcp = $NONE;
> > my $accept_ra = 'false';
> > --
> > 2.30.2
> >
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> >
> >
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2022-07-19 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:24 Oguz Bektas
2022-07-19 11:52 ` Fabian Grünbichler
2022-07-19 11:54 ` Oguz Bektas [this message]
2022-07-22 12:50 ` [pve-devel] applied: " Wolfgang Bumiller
2022-07-25 8:25 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtabimEy5PeG09tP@gaia \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.