From: Oguz Bektas <o.bektas@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v5 manager] ui: vm network: allow to override MTU for virtio devices
Date: Fri, 20 May 2022 10:03:56 +0200 [thread overview]
Message-ID: <YodLbHr7wpUu/f1E@gaia> (raw)
In-Reply-To: <c175eac4-b9c9-dbe9-2a93-bdb4d65ab903@proxmox.com>
On Fri, May 20, 2022 at 09:41:10AM +0200, Thomas Lamprecht wrote:
> On 19/05/2022 10:48, Oguz Bektas wrote:
> > we already have the 'mtu' option in the API, so we can just expose
> > that option inside the 'Advanced' menu for virtio network interfaces.
> >
> > Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
> > Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
> > Tested-By: Dylan Whyte <d.whyte@proxmox.com>
>
> aren't those from two version previous with some change in between, or
> did they re-test / re-review this in private?
> As IMO it's not really correct to let one believe that this exact version
> was tested by two people.
sorry for the confusion, the tags were leftover from the previous
commits
>
> Functionality wise it looks Ok, a few final layout and code style nits
> I'd still like to see inline.
i've addressed the nits in the v6.
though i don't think the
> "Use the special value '1' to inherit the MTU from the underlying bridge"
is the best, since the user won't see this message until they've
selected '1' as a value.
regardless, i've made the changes you asked for
- oguz
next prev parent reply other threads:[~2022-05-20 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 8:48 Oguz Bektas
2022-05-20 7:41 ` Thomas Lamprecht
2022-05-20 8:03 ` Oguz Bektas [this message]
2022-05-20 8:19 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YodLbHr7wpUu/f1E@gaia \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.