From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "David Riley" <d.riley@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-manager v2 2/2] fix #8006: api: acme: lifetime-based certificate renewal threshold
Date: Tue, 20 Oct 2026 15:32:20 +0200 [thread overview]
Message-ID: <DM9PBYPJ4DPZ.3R9YV8PV48STL@proxmox.com> (raw)
In-Reply-To: <20261020082415.35215-3-d.riley@proxmox.com>
nit: IMO the pveupdate change would make more sense as a separate
commit. Or at least the commit subject should be adapted, as it
currently only mentions "api: acme:", which is a bit misleading.
On Tue Oct 20, 2026 at 10:24 AM CEST, David Riley wrote:
> Replace the hardcoded 30-day renewal limit with a threshold based on
> the certificate's actual lifetime.
>
> The previous hardcoded limit caused excessive daily renewals for
> short-lived certificates (e.g., 31 days). This change ensures they
> renew at sensible intervals, avoiding upstream rate limits.
>
> Link: https://bugzilla.proxmox.com/show_bug.cgi?id=8006
>
> Signed-off-by: David Riley <d.riley@proxmox.com>
> ---
> PVE/API2/ACME.pm | 10 ++++++----
> bin/pveupdate | 4 +++-
> 2 files changed, 9 insertions(+), 5 deletions(-)
[snip]
next prev parent reply other threads:[~2026-10-20 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 8:24 [PATCH common/manager v2 0/2] fix #8006: acme: lifetime-based certificate renewal threshold David Riley
2026-10-20 8:24 ` [PATCH pve-common v2 1/2] certificate: add helpers for lifetime-based ACME renewal David Riley
2026-10-20 13:34 ` Michael Köppl
2026-10-20 8:24 ` [PATCH pve-manager v2 2/2] fix #8006: api: acme: lifetime-based certificate renewal threshold David Riley
2026-10-20 13:32 ` Michael Köppl [this message]
2026-10-20 13:34 ` [PATCH common/manager v2 0/2] fix #8006: " Michael Köppl
2026-10-21 9:58 ` superseded: " David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM9PBYPJ4DPZ.3R9YV8PV48STL@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.