From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B5A331FF0AA for ; Tue, 20 Oct 2026 15:32:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C6015216A8; Tue, 20 Oct 2026 15:32:26 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Tue, 20 Oct 2026 15:32:20 +0200 Message-Id: Subject: Re: [PATCH pve-manager v2 2/2] fix #8006: api: acme: lifetime-based certificate renewal threshold From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "David Riley" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0 References: <20261020082415.35215-1-d.riley@proxmox.com> <20261020082415.35215-3-d.riley@proxmox.com> In-Reply-To: <20261020082415.35215-3-d.riley@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792503140669 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.243 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6NHHKNMZRQX6GCBQ4F2EPU7FOUAYPTY4 X-Message-ID-Hash: 6NHHKNMZRQX6GCBQ4F2EPU7FOUAYPTY4 X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: nit: IMO the pveupdate change would make more sense as a separate commit. Or at least the commit subject should be adapted, as it currently only mentions "api: acme:", which is a bit misleading. On Tue Oct 20, 2026 at 10:24 AM CEST, David Riley wrote: > Replace the hardcoded 30-day renewal limit with a threshold based on > the certificate's actual lifetime. > > The previous hardcoded limit caused excessive daily renewals for > short-lived certificates (e.g., 31 days). This change ensures they > renew at sensible intervals, avoiding upstream rate limits. > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=3D8006 > > Signed-off-by: David Riley > --- > PVE/API2/ACME.pm | 10 ++++++---- > bin/pveupdate | 4 +++- > 2 files changed, 9 insertions(+), 5 deletions(-) [snip]