Re: [PATCH docs/guest-common/qemu-server v5 0/9] add new pci passthrough specific hookscript phase

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

Testing
-------
Tested this by setting frame_rate_limiter=1 and frame_rate_limiter=0
on NVIDIA RTX A5000 with vGPU  Driver Version: 595.91.04

With frame_rate_limiter=1:
output of: nvidia-smi vgpu -q
Frame Rate Limit                  : 45 FPS

With frame_rate_limiter=0:
output of: nvidia-smi vgpu -q
Frame Rate Limit                  : N/A

Changes v4->v5
--------------
Changes also seem sensible!


Consider this:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Wed Sep 23, 2026 at 9:04 AM CEST, Dominik Csapak wrote:
> this series adds a new phase to the guest hookscript that is called for each
> passed throug pci device after it's prepared, but before the qemu process is
> started.
>
> See the last qemu-server commit for why that is interesting.
>
> changes from v4:
> * fixed code style
> * improved comment for ENV copying
> * added cleanup commit for renaming variable
> * added commit to downgrade to warn for unknown phases in example hookscript
>
> changes from v3:
> * rebase on current master
> * fix `local %ENV` clearing the whole environment instead of
>   just shadowing it, so the hookscript keeps the inherited environment
> * split the uuid handling out of the refactoring commit
> * call the hookscript once for both the mdev and the plain passthrough
>   case instead of duplicating the call in both branches
> * add missing `use PVE::GuestHelpers;`
> * move the new phase before 'post-start' to match the actual call
>   order, document that PVE_HOOK_MDEV_UUID is only set for mdevs, and
>   mention what the phase is useful for
> * fix typos
>
> changes from v2:
> * rebase on current master
> * prefix hook script env variables with 'PVE_HOOK_'
>
>
> pve-guest-common:
>
> Dominik Csapak (1):
>   helpers: exec hookscript: add optional parameters
>
>  src/PVE/GuestHelpers.pm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
>
> qemu-server:
>
> Dominik Csapak (6):
>   pci: mdev preparation: always generate local uuid first
>   pci: nvidia vgpu: correct wrong comment about uuid
>   pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module
>   code cleanup: pci: rename 'd' variable to 'pci_device'
>   pci: preparation: mdev: only generate uuid once
>   pci: call hookscript for each prepared pci device
>
>  src/PVE/QemuServer.pm     | 45 ++++++---------------------------
>  src/PVE/QemuServer/PCI.pm | 52 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 37 deletions(-)
>
>
> pve-docs:
>
> Dominik Csapak (2):
>   examples: add new hookscript phase to example hookscript
>   examples: downgrade 'die' in example hookscript to 'warn'
>
>  examples/guest-example-hookscript.pl | 31 +++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)
>
>
> Summary over all repositories:
>   4 files changed, 101 insertions(+), 39 deletions(-)