all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH docs/guest-common/qemu-server v5 0/9] add new pci passthrough specific hookscript phase
Date: Wed, 23 Sep 2026 09:04:53 +0200	[thread overview]
Message-ID: <20260923070522.434715-1-d.csapak@proxmox.com> (raw)

this series adds a new phase to the guest hookscript that is called for each
passed throug pci device after it's prepared, but before the qemu process is
started.

See the last qemu-server commit for why that is interesting.

changes from v4:
* fixed code style
* improved comment for ENV copying
* added cleanup commit for renaming variable
* added commit to downgrade to warn for unknown phases in example hookscript

changes from v3:
* rebase on current master
* fix `local %ENV` clearing the whole environment instead of
  just shadowing it, so the hookscript keeps the inherited environment
* split the uuid handling out of the refactoring commit
* call the hookscript once for both the mdev and the plain passthrough
  case instead of duplicating the call in both branches
* add missing `use PVE::GuestHelpers;`
* move the new phase before 'post-start' to match the actual call
  order, document that PVE_HOOK_MDEV_UUID is only set for mdevs, and
  mention what the phase is useful for
* fix typos

changes from v2:
* rebase on current master
* prefix hook script env variables with 'PVE_HOOK_'


pve-guest-common:

Dominik Csapak (1):
  helpers: exec hookscript: add optional parameters

 src/PVE/GuestHelpers.pm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)


qemu-server:

Dominik Csapak (6):
  pci: mdev preparation: always generate local uuid first
  pci: nvidia vgpu: correct wrong comment about uuid
  pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module
  code cleanup: pci: rename 'd' variable to 'pci_device'
  pci: preparation: mdev: only generate uuid once
  pci: call hookscript for each prepared pci device

 src/PVE/QemuServer.pm     | 45 ++++++---------------------------
 src/PVE/QemuServer/PCI.pm | 52 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+), 37 deletions(-)


pve-docs:

Dominik Csapak (2):
  examples: add new hookscript phase to example hookscript
  examples: downgrade 'die' in example hookscript to 'warn'

 examples/guest-example-hookscript.pl | 31 +++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)


Summary over all repositories:
  4 files changed, 101 insertions(+), 39 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-09-23  7:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  7:04 Dominik Csapak [this message]
2026-09-23  7:04 ` [PATCH guest-common v5 1/9] helpers: exec hookscript: add optional parameters Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 2/9] pci: mdev preparation: always generate local uuid first Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 3/9] pci: nvidia vgpu: correct wrong comment about uuid Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 4/9] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 5/9] code cleanup: pci: rename 'd' variable to 'pci_device' Dominik Csapak
2026-09-23  7:04 ` [PATCH qemu-server v5 6/9] pci: preparation: mdev: only generate uuid once Dominik Csapak
2026-09-23  7:05 ` [PATCH qemu-server v5 7/9] pci: call hookscript for each prepared pci device Dominik Csapak
2026-09-23  7:05 ` [PATCH docs v5 8/9] examples: add new hookscript phase to example hookscript Dominik Csapak
2026-09-23  7:05 ` [PATCH docs v5 9/9] examples: downgrade 'die' in example hookscript to 'warn' Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923070522.434715-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal