From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager/yew-widget-toolkit v2 0/3] ui: persist the main menus expanded state
Date: Fri, 02 Oct 2026 13:53:07 +0200 [thread overview]
Message-ID: <DLUBY6WSUTR9.1IKXJK5B00G3Y@proxmox.com> (raw)
In-Reply-To: <20260904102643.3563579-1-d.csapak@proxmox.com>
On Fri Sep 4, 2026 at 12:26 PM CEST, Dominik Csapak wrote:
> By saving the state in the browsers local storage.
>
> It also fixes an issue where menus that were collapsed by default wouldn't open
> on the first click.
>
> Note that for the pdm patches, pwt must be bumped and the new version must be
> recorded in Cargo.toml.
>
> the mechanism did change a bit, so i left out the r-b and t-b from lukas
> (Thanks though!)
Gave this another test, works fine as far as I can tell!
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Code looks also fine from what I can tell, not a super deep review
though:
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
prev parent reply other threads:[~2026-10-02 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 10:26 [PATCH datacenter-manager/yew-widget-toolkit v2 0/3] ui: persist the main menus expanded state Dominik Csapak
2026-09-04 10:26 ` [PATCH yew-widget-toolkit v2 1/3] widget: navigation drawer: fix first open for default collapsed menus Dominik Csapak
2026-09-04 10:26 ` [PATCH yew-widget-toolkit v2 2/3] widget: navigation drawer: allow persisting the expanded state Dominik Csapak
2026-09-04 10:26 ` [PATCH datacenter-manager v2 3/3] ui: main menu: make expanded/collapsed state persistent Dominik Csapak
2026-10-02 11:53 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLUBY6WSUTR9.1IKXJK5B00G3Y@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.