From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 85E431FF0B7 for ; Fri, 02 Oct 2026 13:53:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 25A7A21683; Fri, 02 Oct 2026 13:53:10 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 02 Oct 2026 13:53:07 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager/yew-widget-toolkit v2 0/3] ui: persist the main menus expanded state From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260904102643.3563579-1-d.csapak@proxmox.com> In-Reply-To: <20260904102643.3563579-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790941987633 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.362 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2JGCJVPMFLFWILQ7PUGQBXKBEH7NTAI2 X-Message-ID-Hash: 2JGCJVPMFLFWILQ7PUGQBXKBEH7NTAI2 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Sep 4, 2026 at 12:26 PM CEST, Dominik Csapak wrote: > By saving the state in the browsers local storage. > > It also fixes an issue where menus that were collapsed by default wouldn'= t open > on the first click. > > Note that for the pdm patches, pwt must be bumped and the new version mus= t be > recorded in Cargo.toml. > > the mechanism did change a bit, so i left out the r-b and t-b from lukas > (Thanks though!) Gave this another test, works fine as far as I can tell! Tested-by: Lukas Wagner Code looks also fine from what I can tell, not a super deep review though: Reviewed-by: Lukas Wagner