all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox] installer-types: align documentation of hdsize for btrfs with lvm & zfs
Date: Thu, 24 Sep 2026 11:33:21 +0200	[thread overview]
Message-ID: <DLNFYTOA1P41.6K1F00GICAND@proxmox.com> (raw)
In-Reply-To: <20260713092234.73883-1-s.sterz@proxmox.com>

On Mon Jul 13, 2026 at 11:22 AM CEST, Shannon Sterz wrote:
> to avoid confusion. the hdsize is used to determine how much space is
> available for partitioning. it is not the size of the btrfs partition
> itself. the `LvmOptions` and `ZfsOptions` already specify this
> correctly, so align the documentation here to avoid confusion.

Thanks for noticing and fixing it - was probably a simple copy-paste
error by me.

Consider it:

Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>

>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  proxmox-installer-types/src/answer.rs | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs
> index 8490d3d6..f07d9f7f 100644
> --- a/proxmox-installer-types/src/answer.rs
> +++ b/proxmox-installer-types/src/answer.rs
> @@ -957,8 +957,7 @@ pub struct LvmOptions {
>  /// Btrfs-specific filesystem options.
>  pub struct BtrfsOptions {
>      #[serde(skip_serializing_if = "Option::is_none")]
> -    /// Size of the root partition. Optional, will be heuristically determined if
> -    /// unset.
> +    /// Size of the root disk. Optional, will be heuristically determined if unset.
>      pub hdsize: Option<f64>,
>      #[serde(skip_serializing_if = "Option::is_none")]
>      /// RAID level to use.






      reply	other threads:[~2026-09-24  9:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  9:22 [PATCH proxmox] installer-types: align documentation of hdsize for btrfs with lvm & zfs Shannon Sterz
2026-09-24  9:33 ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLNFYTOA1P41.6K1F00GICAND@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal