From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id E435F1FF0AF
	for <inbox@lore.proxmox.com>; Thu, 24 Sep 2026 11:33:29 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 399FA21637;
	Thu, 24 Sep 2026 11:33:27 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 24 Sep 2026 11:33:21 +0200
Message-Id: <DLNFYTOA1P41.6K1F00GICAND@proxmox.com>
Subject: Re: [PATCH proxmox] installer-types: align documentation of hdsize
 for btrfs with lvm & zfs
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
X-Mailer: aerc 0.22.0
References: <20260713092234.73883-1-s.sterz@proxmox.com>
In-Reply-To: <20260713092234.73883-1-s.sterz@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790242401914
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.319 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: DZIZQFR72RNPMCUL4K632NQVGDRCM74J
X-Message-ID-Hash: DZIZQFR72RNPMCUL4K632NQVGDRCM74J
X-MailFrom: c.heiss@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Mon Jul 13, 2026 at 11:22 AM CEST, Shannon Sterz wrote:
> to avoid confusion. the hdsize is used to determine how much space is
> available for partitioning. it is not the size of the btrfs partition
> itself. the `LvmOptions` and `ZfsOptions` already specify this
> correctly, so align the documentation here to avoid confusion.

Thanks for noticing and fixing it - was probably a simple copy-paste
error by me.

Consider it:

Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>

>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  proxmox-installer-types/src/answer.rs | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-ty=
pes/src/answer.rs
> index 8490d3d6..f07d9f7f 100644
> --- a/proxmox-installer-types/src/answer.rs
> +++ b/proxmox-installer-types/src/answer.rs
> @@ -957,8 +957,7 @@ pub struct LvmOptions {
>  /// Btrfs-specific filesystem options.
>  pub struct BtrfsOptions {
>      #[serde(skip_serializing_if =3D "Option::is_none")]
> -    /// Size of the root partition. Optional, will be heuristically dete=
rmined if
> -    /// unset.
> +    /// Size of the root disk. Optional, will be heuristically determine=
d if unset.
>      pub hdsize: Option<f64>,
>      #[serde(skip_serializing_if =3D "Option::is_none")]
>      /// RAID level to use.