Re: [PATCH datacenter-manager/installer/proxmox v2 00/16] auto-installer: add installed target systems as new remotes

["Thomas Ellmenreich" <t.ellmenreich@proxmox.com>]

After struggling a little bit to get the repositories to build and an ISO
patched, the automatic installing worked perfectly.

I created a new "Prepared Answer" on my PDM instance and then pasted the
correct URL, fingerprint, ... to the ISO. Having ticked the "Provision As
New Remote" checkbox in the Authentication tab, after successful installation,
the machine was added to PDM as a remote.

Aside from having the patches applied to the installer and PDM, I have also
tried the following combinations:
  * only patching the installer
  * only patching PDM and ticking the checkbox in the answer sheet
  * as a baseline, I also tested the auto installer without patches
  * since PBS is also supported, I also tested that

All of the cases mentioned above worked well, although there are two small
things that I noticed. Since my knowledge in this domain is limited, I'm not
100% sure if this is the correct place to mention them, but I will do so
anyway:

1. Faulty Datacenter Manager URL

During my first autoinstall, I had the URL to the PDM instance set with a
incorrect domain name, which led to this error during the installation:

    > ...
    > Unmounting "/target/dev"
    > Unmounting "/target/proc"
    > Unmounting "/target/run"
    > Unmounting "/target/sys"
    > Chroot cleanup done. You can now reboot or leave the shell.
    >
    > Error occurred during post-installation-webhook:
    > io: falied to look up address information: Name or service not known
    > Post-installation hook failed (exit-code 0) - see above for errors.
    >
    > Installation aborted - unable to continue (type exit or CTRL-D to reboot)


Reading these last lines, I was not sure if the installation had succeeded or
not. A restart did confirm that everything was alright and that the
installation did succeed.

Maybe the logs can be reworked to not send such mixed signals.

2. Installation Status in PDM

During one of the initial installations, I had misconfigured the network
device filters and thus the installation failed. Opening the PDM webui and
going under "Automated Installations", these failed attempts still retain the
"In Progress" status.

I don't think this is a problem, but just a thing I noticed. I'm also aware
that adding a "Failed" state, as well as the machinery to set such a state on
error, could be a bigger change, and thus better suited to a separate series.

---

That said, both of these are not blockers, so consider this:

Reviewed-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Tested-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>