all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager/installer/proxmox v2 00/16] auto-installer: add installed target systems as new remotes
Date: Wed, 26 Aug 2026 13:04:43 +0200	[thread overview]
Message-ID: <20260826110504.1339934-1-c.heiss@proxmox.com> (raw)

Adds a new checkbox to the "Authentication" tab of the wizard for
creating/editing prepared auto-installer answers.

When checked, the installer (in the post-hook) will create a new API
token on the freshly installed system - akin to how PDM does it when
creating a new token - and adds it a remote.

Of course; only supported when installing PVE or PBS, as these are the
supported targets of PDM.

The post-hook information schema (which is sent back to the answer
server) is expanded a bit to accommodate that with two new fields:

- `cert-fingerprint`: The SHA256 fingerprint for the API, needed due to
  the default self-signed certificates.
- `api-token`: Holds the ID of the created token and its secret.

Apply order
===========

Same as the repo order in the patch series, i.e. the `proxmox` part
first, then `pve-installer` and `proxmox-datacenter-manager` need their
dependency on `proxmox-installer-types` bumped accordingly.

Testing
=======

I've tested both following combinations; each with all products as
possible:

- Current PDM (1.1.7) with patched ISOs (i.e. w/ patches from this
  series)
- Patched PDM (i.e. w/ patches from this series) with current ISOs
  (PVE 9.2-1, PBS 4.2-1, PMG 9.1-1, PDM 1.1-1)
- Patched PDM w/ patched ISOs

History
=======

v1: https://lore.proxmox.com/pdm-devel/20260731143910.936881-1-c.heiss@proxmox.com/

Notable changes v1 -> v2:
  * rebased all on latest masters
  * addressed review comments from Lukas

Diffstat
========

proxmox:

Christoph Heiss (5):
  installer-types: drop unnecessary clippy attribute
  installer-types: post-hook: factor schema version into proper struct
  installer-types: post-hook: allow additional properties on api schema
  installer-types: post-hook: add api-token and cert-fingerprint options
  installer-types: systeminfo: add check for API token creation
    capability

 proxmox-installer-types/Cargo.toml       |  1 +
 proxmox-installer-types/debian/control   |  4 ++
 proxmox-installer-types/src/answer.rs    | 65 +++++++++++++++--
 proxmox-installer-types/src/lib.rs       | 89 +++++++++++++++++++++++-
 proxmox-installer-types/src/post_hook.rs | 50 +++++++++++--
 5 files changed, 196 insertions(+), 13 deletions(-)

pve-installer:

Christoph Heiss (6):
  chroot: print full error if bind-mounting fails
  post-hook: re-use low-level config retrieval from proxmox-chroot
  post-hook: generate and retrieve node certificate fingerprint
  post-hook: support creating API token if requested in answer file
  auto: enforce https for post hook when generating an API token
  assistant: validate-answer: also verify post-hook settings if set

 Cargo.toml                                 |   6 +-
 debian/control                             |   1 +
 proxmox-auto-install-assistant/src/main.rs |   7 +-
 proxmox-auto-installer/src/utils.rs        |  16 +-
 proxmox-chroot/src/main.rs                 |  16 +-
 proxmox-installer-common/Cargo.toml        |   4 +-
 proxmox-installer-common/src/setup.rs      |  12 +
 proxmox-post-hook/Cargo.toml               |   5 +-
 proxmox-post-hook/src/main.rs              | 291 ++++++++++++++++++++-
 9 files changed, 327 insertions(+), 31 deletions(-)

proxmox-datacenter-manager:

Christoph Heiss (5):
  ui: auto-installer: spell out Proxmox Datacenter Manager
  config: auto-install: add optional `post-hook-add-as-remote` field
  api: auto-installer: add option for adding new remotes to PDM
  ui: auto-installer: wizard: add checkbox to add target as new remote
  docs: auto-installer: document adding targets as remotes afterwards

 docs/automated-installations.rst              |  39 ++++-
 lib/pdm-api-types/src/auto_installer.rs       |  10 ++
 lib/pdm-config/src/auto_install.rs            |  14 ++
 server/src/api/auto_installer/mod.rs          | 157 +++++++++++++++---
 .../prepared_answer_add_wizard.rs             |   1 +
 .../auto_installer/prepared_answer_form.rs    |   9 +-
 6 files changed, 205 insertions(+), 25 deletions(-)




             reply	other threads:[~2026-08-26 11:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 11:04 Christoph Heiss [this message]
2026-08-26 11:04 ` [PATCH proxmox v2 01/16] installer-types: drop unnecessary clippy attribute Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 02/16] installer-types: post-hook: factor schema version into proper struct Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 03/16] installer-types: post-hook: allow additional properties on api schema Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 04/16] installer-types: post-hook: add api-token and cert-fingerprint options Christoph Heiss
2026-08-26 11:04 ` [PATCH proxmox v2 05/16] installer-types: systeminfo: add check for API token creation capability Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 06/16] chroot: print full error if bind-mounting fails Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 07/16] post-hook: re-use low-level config retrieval from proxmox-chroot Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 08/16] post-hook: generate and retrieve node certificate fingerprint Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 09/16] post-hook: support creating API token if requested in answer file Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 10/16] auto: enforce https for post hook when generating an API token Christoph Heiss
2026-08-26 11:04 ` [PATCH installer v2 11/16] assistant: validate-answer: also verify post-hook settings if set Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 12/16] ui: auto-installer: spell out Proxmox Datacenter Manager Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 13/16] config: auto-install: add optional `post-hook-add-as-remote` field Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 14/16] api: auto-installer: add option for adding new remotes to PDM Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 15/16] ui: auto-installer: wizard: add checkbox to add target as new remote Christoph Heiss
2026-08-26 11:04 ` [PATCH datacenter-manager v2 16/16] docs: auto-installer: document adding targets as remotes afterwards Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260826110504.1339934-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal