From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v4 08/21] remote iterator: pass remote config reader explicitly
Date: Thu, 03 Sep 2026 11:33:35 +0200 [thread overview]
Message-ID: <DL5KTJVQISD9.2N60CSGGTLRY5@proxmox.com> (raw)
In-Reply-To: <20260903065016.31726-9-l.wagner@proxmox.com>
This one doesn't seem to apply anymore (due to
8f962b5917fab2e63868a5f68eab22edcdfec570, I think). Will still continue
to review, just wanted to point it out.
On Thu Sep 3, 2026 at 8:50 AM CEST, Lukas Wagner wrote:
> This will be useful later once we get a reference to the remote config
> implementation via the application context object. Also, it gently
> nudges developers to think about the previously hidden dependency.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> lib/pdm-config/src/remotes.rs | 2 +-
> server/src/api/pbs/mod.rs | 10 ++++------
> server/src/api/pve/firewall.rs | 3 ++-
> server/src/api/pve/mod.rs | 3 ++-
> server/src/api/remotes/mod.rs | 5 +++--
> server/src/api/remotes/updates.rs | 3 ++-
> server/src/api/sdn/controllers.rs | 2 +-
> server/src/api/sdn/vnets.rs | 2 +-
> server/src/api/sdn/zones.rs | 2 +-
> server/src/api/subscriptions/mod.rs | 10 ++++++----
[snip]
next prev parent reply other threads:[~2026-09-03 9:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 6:49 [PATCH datacenter-manager/proxmox v4 00/21] inject application context via API macro for easier integration testing Lukas Wagner
2026-09-03 6:49 ` [PATCH proxmox v4 01/21] router: introduce shared state Lukas Wagner
2026-09-03 6:49 ` [PATCH proxmox v4 02/21] rest-server: allow to inject " Lukas Wagner
2026-09-03 6:49 ` [PATCH proxmox v4 03/21] api-macro: support shared state extraction type Lukas Wagner
2026-09-03 8:25 ` Lukas Wagner
2026-09-03 6:49 ` [PATCH proxmox v4 04/21] product-config: add ProductConfig type Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 05/21] context: promote context to a dir-style module Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 06/21] pdm-config: remotes: rename trait methods to read/write/lock Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 07/21] pdm-config: subscriptions: " Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 08/21] remote iterator: pass remote config reader explicitly Lukas Wagner
2026-09-03 9:33 ` Michael Köppl [this message]
2026-09-03 9:41 ` Michael Köppl
2026-09-03 6:50 ` [PATCH datacenter-manager v4 09/21] context: introduce a ContextFactory to build application context Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 10/21] context: establish PdmApplication object Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 11/21] context: register PdmApplication in router Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 12/21] connection: use client factory from PdmApplication handle Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 13/21] parallel fetcher: pass arguments to closure in a single type Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 14/21] server: migrate existing ParallelFetcher users to use PdmApplication Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 15/21] tests: add helpers for building API-handler-level integration tests Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 16/21] tests: add example tests for SDN API routes Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 17/21] api-cache: add wrapper type Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 18/21] context: provide api-cache on the app object Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 19/21] api: subscriptions: use PdmApplication instead of globals Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 20/21] pdm-config: subscriptions: drop unused accessor functions Lukas Wagner
2026-09-03 6:50 ` [PATCH datacenter-manager v4 21/21] tests: add example tests for remote subscription management Lukas Wagner
2026-09-03 11:17 ` superseded: [PATCH datacenter-manager/proxmox v4 00/21] inject application context via API macro for easier integration testing Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL5KTJVQISD9.2N60CSGGTLRY5@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.