From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8F41B1FF09F for ; Thu, 03 Sep 2026 11:33:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EB96F2158D; Thu, 03 Sep 2026 11:33:40 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 03 Sep 2026 11:33:35 +0200 Message-Id: To: "Lukas Wagner" , Subject: Re: [PATCH datacenter-manager v4 08/21] remote iterator: pass remote config reader explicitly From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.22.0 References: <20260903065016.31726-1-l.wagner@proxmox.com> <20260903065016.31726-9-l.wagner@proxmox.com> In-Reply-To: <20260903065016.31726-9-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788428012708 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.926 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: D24FUKNJY3ANQZAL5LTJMQUMSXYT5NNC X-Message-ID-Hash: D24FUKNJY3ANQZAL5LTJMQUMSXYT5NNC X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This one doesn't seem to apply anymore (due to 8f962b5917fab2e63868a5f68eab22edcdfec570, I think). Will still continue to review, just wanted to point it out. On Thu Sep 3, 2026 at 8:50 AM CEST, Lukas Wagner wrote: > This will be useful later once we get a reference to the remote config > implementation via the application context object. Also, it gently > nudges developers to think about the previously hidden dependency. > > Signed-off-by: Lukas Wagner > --- > lib/pdm-config/src/remotes.rs | 2 +- > server/src/api/pbs/mod.rs | 10 ++++------ > server/src/api/pve/firewall.rs | 3 ++- > server/src/api/pve/mod.rs | 3 ++- > server/src/api/remotes/mod.rs | 5 +++-- > server/src/api/remotes/updates.rs | 3 ++- > server/src/api/sdn/controllers.rs | 2 +- > server/src/api/sdn/vnets.rs | 2 +- > server/src/api/sdn/zones.rs | 2 +- > server/src/api/subscriptions/mod.rs | 10 ++++++---- [snip]