Re: [PATCH proxmox-backup v2 0/6] fix #7024: add more information inside backup logs

["Thomas Ellmenreich" <t.ellmenreich@proxmox.com>]

So I tested the problematic codepath again and now everything works
as expected, so consider this:

Reviewed-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Tested-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>

On Thu Jul 16, 2026 at 5:30 PM CEST, Shan Shaji wrote:
> This series addresses three issues:
>   - File number statistics not being shown under change detection
>     summary for data and legacy mode.
>   - The pogress logs were not showing the number of processed files.
>   - There was no verbose option.
>
> Changes since v1: Thank to @Thomas Ellmenreich
>   - Patch 5/6: When the change detection mode was "legacy" the logs were
>     not being shown inside the console. This was because the callback
>     was not being passed into the upload_stream function which was
>     responsible for uploading the unified pxar archive chunks.
>
>     If we pass the callback, the metadata upload progress will also be
>     logged when the change detection mode is set to 'data' or 'metadata'.
>     This logged information is not useful, and previously, we did not
>     log it. To avoid logging the metadata upload progress, the callback
>     is now attached to the UploadOptions before passing them to the
>     unified pxar archive upload_stream function only if the
>     payload_stream is 'none'.
>
> Changes since RFC: Thanks to @Christian Ebner
>   - Patch 2/6: Add more helper functions to PxarArchiverProgressStats
>     and change their visibility to pub(crate).
>   - Patch 3/6: Use the new helper functions to show the summary for
>     both legacy mode and data mode.
>   - Patch 4/6: Add a preparatory patch for sharing UploadCounters
>     inside the progress logger callback used in patch 5/6.
>   - Patch 5/6: Instead of passing PxarArchiverProgressStats around,
>     add a callback to UploadOptions that accepts UploadCounters and
>     TimeSpan as parameters. At the UploadOptions creation site, a
>     closure can then be passed that takes the pxar archiver stats and
>     logs the output.
>   - Patch 6/6: Instead of switching the log level based on the verbose
>     flag, bump the log level to info and gate the output behind the
>     verbose flag.
>   - Reword and fix some commit body messages. 
>
> Shan Shaji (6):
>   client: pxar: rename `ReuseStats` struct to PxarArchiverProgressStats
>   client: pxar:  use atomic values in `PxarArchiverProgressStats`
>   fix #7024: pxar: show archiver summary for legacy and data mode
>   client: backup_stats: move `uploaded_len` counter to `UploadCounters`
>   fix #7024: cli: add more information inside the backup progress logs
>   fix #7024: cli: add option to enable verbose logs
>
>  pbs-client/src/backup_stats.rs                |  16 +-
>  pbs-client/src/backup_writer.rs               |  43 ++---
>  pbs-client/src/lib.rs                         |   2 +-
>  pbs-client/src/pxar/create.rs                 | 179 ++++++++++++++----
>  pbs-client/src/pxar/mod.rs                    |   3 +-
>  pbs-client/src/pxar/tools.rs                  |   9 +-
>  pbs-client/src/pxar_backup_stream.rs          |  13 +-
>  proxmox-backup-client/src/main.rs             |  79 +++++++-
>  .../src/proxmox_restore_daemon/api.rs         |   2 +
>  pxar-bin/src/main.rs                          |   2 +
>  tests/catar.rs                                |   1 +
>  11 files changed, 272 insertions(+), 77 deletions(-)