From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 60A791FF0E3 for ; Tue, 04 Aug 2026 13:47:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 32F9E216CF; Tue, 04 Aug 2026 13:47:59 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 04 Aug 2026 13:47:54 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup v2 0/6] fix #7024: add more information inside backup logs From: "Thomas Ellmenreich" To: "Shan Shaji" , X-Mailer: aerc 0.20.0 References: <20260716153012.129538-1-s.shaji@proxmox.com> In-Reply-To: <20260716153012.129538-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785844062246 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.073 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2JHB7RW3VD3NQZFRCYJALXEMEAMZIHUX X-Message-ID-Hash: 2JHB7RW3VD3NQZFRCYJALXEMEAMZIHUX X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: So I tested the problematic codepath again and now everything works as expected, so consider this: Reviewed-by: Thomas Ellmenreich Tested-by: Thomas Ellmenreich On Thu Jul 16, 2026 at 5:30 PM CEST, Shan Shaji wrote: > This series addresses three issues: > - File number statistics not being shown under change detection > summary for data and legacy mode. > - The pogress logs were not showing the number of processed files. > - There was no verbose option. > > Changes since v1: Thank to @Thomas Ellmenreich > - Patch 5/6: When the change detection mode was "legacy" the logs were > not being shown inside the console. This was because the callback > was not being passed into the upload_stream function which was > responsible for uploading the unified pxar archive chunks. > > If we pass the callback, the metadata upload progress will also be > logged when the change detection mode is set to 'data' or 'metadata'. > This logged information is not useful, and previously, we did not > log it. To avoid logging the metadata upload progress, the callback > is now attached to the UploadOptions before passing them to the > unified pxar archive upload_stream function only if the > payload_stream is 'none'. > > Changes since RFC: Thanks to @Christian Ebner > - Patch 2/6: Add more helper functions to PxarArchiverProgressStats > and change their visibility to pub(crate). > - Patch 3/6: Use the new helper functions to show the summary for > both legacy mode and data mode. > - Patch 4/6: Add a preparatory patch for sharing UploadCounters > inside the progress logger callback used in patch 5/6. > - Patch 5/6: Instead of passing PxarArchiverProgressStats around, > add a callback to UploadOptions that accepts UploadCounters and > TimeSpan as parameters. At the UploadOptions creation site, a > closure can then be passed that takes the pxar archiver stats and > logs the output. > - Patch 6/6: Instead of switching the log level based on the verbose > flag, bump the log level to info and gate the output behind the > verbose flag. > - Reword and fix some commit body messages.=20 > > Shan Shaji (6): > client: pxar: rename `ReuseStats` struct to PxarArchiverProgressStats > client: pxar: use atomic values in `PxarArchiverProgressStats` > fix #7024: pxar: show archiver summary for legacy and data mode > client: backup_stats: move `uploaded_len` counter to `UploadCounters` > fix #7024: cli: add more information inside the backup progress logs > fix #7024: cli: add option to enable verbose logs > > pbs-client/src/backup_stats.rs | 16 +- > pbs-client/src/backup_writer.rs | 43 ++--- > pbs-client/src/lib.rs | 2 +- > pbs-client/src/pxar/create.rs | 179 ++++++++++++++---- > pbs-client/src/pxar/mod.rs | 3 +- > pbs-client/src/pxar/tools.rs | 9 +- > pbs-client/src/pxar_backup_stream.rs | 13 +- > proxmox-backup-client/src/main.rs | 79 +++++++- > .../src/proxmox_restore_daemon/api.rs | 2 + > pxar-bin/src/main.rs | 2 + > tests/catar.rs | 1 + > 11 files changed, 272 insertions(+), 77 deletions(-)