From: "Lukas Sichert" <l.sichert@proxmox.com>
To: "Stefan Hanreich" <s.hanreich@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-common 1/3] iproute2: restructure get_physical_bridge_ports
Date: Mon, 27 Jul 2026 18:13:38 +0200 [thread overview]
Message-ID: <DK9HJ5UD2OZJ.2LTRJWOSJAJG1@proxmox.com> (raw)
In-Reply-To: <20260709132857.239615-2-s.hanreich@proxmox.com>
On 2026-07-09 15:28, Stefan Hanreich <s.hanreich@proxmox.com> wrote:
> By checking first if the interface is a member of the bridge, instead
> of determining its type, a lot of unnecessary checks are not performed
> since checking for membership first is a lot more discriminatory. When
> applying a SDN configuration with 100 VLAN VNets on a non-VLAN-aware
> bridge, this saves a significant amount of statements executed:
>
> without this optimization:
> Executed 438813 statements in 110ms
>
> with this optimization:
> Executed 3693 statements in 10.2ms
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
I tested this on a Machine with 1k QinQ and 1k VLAN VNets. I could
verify a substantial speed increase. In my case it was ~5.5x.
Switching the order to check for the most discriminatory check first
makes sense to me.
Therefore, consider this:
Reviewed-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Lukas Sichert <l.sichert@proxmox.com>
next prev parent reply other threads:[~2026-07-27 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 13:28 [PATCH common/network 0/3] Performance improvements for applying VLAN / QinQ zones Stefan Hanreich
2026-07-09 13:28 ` [PATCH pve-common 1/3] iproute2: restructure get_physical_bridge_ports Stefan Hanreich
2026-07-27 16:13 ` Lukas Sichert [this message]
2026-07-09 13:28 ` [PATCH pve-common 2/3] iproute2: add helper for getting bridge port mappings Stefan Hanreich
2026-07-28 12:00 ` Lukas Sichert
2026-07-09 13:28 ` [PATCH pve-network 3/3] fix #7738: zones: use pre-computed bridge port list Stefan Hanreich
2026-07-28 11:58 ` Lukas Sichert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK9HJ5UD2OZJ.2LTRJWOSJAJG1@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.