[PATCH pve-common 1/3] iproute2: restructure get_physical_bridge_ports

[Stefan Hanreich <s.hanreich@proxmox.com>]

By checking first if the interface is a member of the bridge, instead
of determining its type, a lot of unnecessary checks are not performed
since checking for membership first is a lot more discriminatory. When
applying a SDN configuration with 100 VLAN VNets on a non-VLAN-aware
bridge, this saves a significant amount of statements executed:

without this optimization:
  Executed 438813 statements in 110ms

with this optimization:
  Executed 3693 statements in 10.2ms

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---

Notes:
    This is a remnant from an earlier approach where only the
    ip_link_details output was used, but the bridge ports were still
    recalculated. Nevertheless I decided to still include this patch
    instead of dropping it, since other call sites also profit from it.

 src/PVE/IPRoute2.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
index 53a17b0..ae837dc 100644
--- a/src/PVE/IPRoute2.pm
+++ b/src/PVE/IPRoute2.pm
@@ -83,11 +83,11 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
     }
 
     return grep {
-        (ip_link_is_physical($ip_links->{$_})
+        defined($ip_links->{$_}->{master})
+            && $ip_links->{$_}->{master} eq $bridge
+            && (ip_link_is_physical($ip_links->{$_})
                 || ip_link_is_bond($ip_links->{$_})
                 || ip_link_is_vlan($ip_links->{$_}))
-            && defined($ip_links->{$_}->{master})
-            && $ip_links->{$_}->{master} eq $bridge
     } keys $ip_links->%*;
 }
 
-- 
2.47.3