Re: [PATCH pmg-api/pmg-docs/pmg-gui v3 0/5] tracking-center: make input-base configurable

["Max R. Carrara" <m.carrara@proxmox.com>]

On Fri Jun 12, 2026 at 7:40 PM CEST, Stoiko Ivanov wrote:
> v2->v3:
> * pmg-api patch 2: change the validation from a regex to a validation sub
>   to sanitize the path and prevent curdir and parentdir as well as
>   consecutive slashes
>
> Thanks big-time to Max for checking the series so quickly and for the
> valuable feedback and insight into SectionConfig! I decided to not
> implement some of the suggestions (as talked off-list):
> * root-only vs. root_only - as this is not a user-facing/api parameter,
>   left it in snake_case to not have to quote it.
> * I left the maximal directory depth at 6, as we can very easily extend it
>   if someone requests it, while restricting after having this public would
>       be backwards incompatible
> * pmg currently does not have a concept of api-permissions and not
>   showing/modifying elements where an user has no permissions -
>   implementing this would expand the scope of this small patch series too
>   much (PVE has this in access-control [0]).
> * the docs for pmg.conf get generated automatically based on the property
>   descriptions - see [1].
>
>
> [0] https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=src/PVE/RPCEnvironment.pm;h=7591aa9ed414f4e70b66bc6c40cb054bd2e8231c;hb=5ccd07d9302562b73374d331b63d25b04b86766c#l178
> [1] https://git.proxmox.com/?p=pmg-docs.git;a=blob;f=pmg-doc-generator.mk.in;h=e9253c4a84b0d545021259b68c2051b6697a11f5;hb=b3a0fb7f942001a26d2386e5d1ee47be2b9eaf0b#l51
> v2:
> https://lore.proxmox.com/pmg-devel/DJ5IDD9OR8HE.ENMUIGWPW37U@proxmox.com/T/#t
>
> [...]

Many thanks for the refresh and the kind words!

Everything LGTM -- the patches look neat, and a quick smoke-test
confirmed that the new format added in patch #2 actually does validate
the provided path as expected. Specifically, tried to get it to break
and did not succeed. Nicely done!

One thing I'd suggest for future regexes is to make use of the /x and
/xx modifiers [0], since they really help making regexes much more
readable. Definitely not an issue in this series IMO -- just wanted to
mention it, since people less familiar with Perl may have a hard time
parsing certain REs.

Great work -- since everything's resolved and I couldn't break it,
consider:

Tested-by: Max R. Carrara <m.carrara@proxmox.com>
Reviewed-by: Max R. Carrara <m.carrara@proxmox.com>

[0] https://perldoc.perl.org/perlre#/x-and-/xx