all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [PATCH pmg-api/pmg-docs/pmg-gui v3 0/5] tracking-center: make input-base configurable
Date: Fri, 12 Jun 2026 19:40:57 +0200	[thread overview]
Message-ID: <20260612174145.1190233-1-s.ivanov@proxmox.com> (raw)

v2->v3:
* pmg-api patch 2: change the validation from a regex to a validation sub
  to sanitize the path and prevent curdir and parentdir as well as
  consecutive slashes

Thanks big-time to Max for checking the series so quickly and for the
valuable feedback and insight into SectionConfig! I decided to not
implement some of the suggestions (as talked off-list):
* root-only vs. root_only - as this is not a user-facing/api parameter,
  left it in snake_case to not have to quote it.
* I left the maximal directory depth at 6, as we can very easily extend it
  if someone requests it, while restricting after having this public would
      be backwards incompatible
* pmg currently does not have a concept of api-permissions and not
  showing/modifying elements where an user has no permissions -
  implementing this would expand the scope of this small patch series too
  much (PVE has this in access-control [0]).
* the docs for pmg.conf get generated automatically based on the property
  descriptions - see [1].


[0] https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=src/PVE/RPCEnvironment.pm;h=7591aa9ed414f4e70b66bc6c40cb054bd2e8231c;hb=5ccd07d9302562b73374d331b63d25b04b86766c#l178
[1] https://git.proxmox.com/?p=pmg-docs.git;a=blob;f=pmg-doc-generator.mk.in;h=e9253c4a84b0d545021259b68c2051b6697a11f5;hb=b3a0fb7f942001a26d2386e5d1ee47be2b9eaf0b#l51
v2:
https://lore.proxmox.com/pmg-devel/DJ5IDD9OR8HE.ENMUIGWPW37U@proxmox.com/T/#t


pmg-api:

Stoiko Ivanov (3):
  config: add root_only paramter option.
  config: add log-tracker-base key
  fix #3657: api: tracking center: explicitly set input base from config

 src/PMG/API2/Config.pm      | 10 +++++++++-
 src/PMG/API2/MailTracker.pm |  5 +++++
 src/PMG/Config.pm           | 20 ++++++++++++++++++++
 3 files changed, 34 insertions(+), 1 deletion(-)


pmg-gui:

Stoiko Ivanov (1):
  fix #3657: system options: add log-tracker-base textrow

 js/SystemOptions.js | 6 ++++++
 1 file changed, 6 insertions(+)


pmg-docs:

Stoiko Ivanov (1):
  pmg-log-tracker: mention that input-base can be configured via GUI

 pmg-log-tracker.adoc | 3 +++
 1 file changed, 3 insertions(+)


Summary over all repositories:
  5 files changed, 43 insertions(+), 1 deletions(-)

-- 
Generated by murpp 0.12.0




             reply	other threads:[~2026-06-12 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 17:40 Stoiko Ivanov [this message]
2026-06-12 17:40 ` [PATCH pmg-api v3 1/5] config: add root_only paramter option Stoiko Ivanov
2026-06-12 17:40 ` [PATCH pmg-api v3 2/5] config: add log-tracker-base key Stoiko Ivanov
2026-06-12 17:41 ` [PATCH pmg-api v3 3/5] fix #3657: api: tracking center: explicitly set input base from config Stoiko Ivanov
2026-06-12 17:41 ` [PATCH pmg-gui v3 4/5] fix #3657: system options: add log-tracker-base textrow Stoiko Ivanov
2026-06-12 17:41 ` [PATCH pmg-docs v3 5/5] pmg-log-tracker: mention that input-base can be configured via GUI Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260612174145.1190233-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal