all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager 0/6] improve handling of base url and certificate fingerprint for auto-installer gui
Date: Wed, 27 May 2026 15:11:16 +0200	[thread overview]
Message-ID: <DITHGAKW4EE7.3653FIV8LKNFI@proxmox.com> (raw)
In-Reply-To: <20260527125217.260760-1-s.sterz@proxmox.com>

On Wed May 27, 2026 at 2:52 PM CEST, Shannon Sterz wrote:
> the goal of this series is to make the base url and certificate
> fingerprint handling a bit more intuitive for the auto installer gui.
> the first couple of patches allow the ui to query the host's
> certificate fingerprint. this information is then used to first set
> the initial values for a new answer and also to format the preparation
> command.
>
> Shannon Sterz (6):
>   server: api: certificates: allow anybody to query the certificate info
>   pdm-client: add function to query the PDM hosts certificate info
>   ui: remotes: auto-installer: set pdm_origin() as placeholder not tip
>   ui: remotes: auto-installer: use pdm_origin() to set initial pdm url
>   ui: auto-installer: load fingerprint and use it as initial value
>   ui: auto-installer: use info from answer to format preparation command
>
>  lib/pdm-client/src/lib.rs                     | 12 +++++-
>  server/src/api/nodes/certificates.rs          |  2 +-
>  ui/src/remotes/auto_installer/mod.rs          |  8 ++++
>  .../prepared_answer_add_wizard.rs             |  7 ++--
>  .../auto_installer/prepared_answer_form.rs    | 31 ++++++++------
>  .../auto_installer/prepared_answers_panel.rs  | 41 ++++++++++++++++++-
>  ui/src/remotes/auto_installer/token_panel.rs  | 20 +++++++++
>  7 files changed, 101 insertions(+), 20 deletions(-)
>
> --
> 2.47.3

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

If exposing the entire certificate info is deemed to dangererous, I
suppose we could add a new endpoint which just returns the fingerprint.
But to me, after checking the fields of the CertificateInfo type, it
seems fine as is.




  parent reply	other threads:[~2026-05-27 13:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 12:52 [PATCH datacenter-manager 0/6] improve handling of base url and certificate fingerprint for auto-installer gui Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 1/6] server: api: certificates: allow anybody to query the certificate info Shannon Sterz
2026-05-27 14:12   ` Filip Schauer
2026-05-27 14:16     ` Lukas Wagner
2026-05-27 14:17       ` Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 2/6] pdm-client: add function to query the PDM hosts " Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 3/6] ui: remotes: auto-installer: set pdm_origin() as placeholder not tip Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 4/6] ui: remotes: auto-installer: use pdm_origin() to set initial pdm url Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 5/6] ui: auto-installer: load fingerprint and use it as initial value Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 6/6] ui: auto-installer: use info from answer to format preparation command Shannon Sterz
2026-05-27 13:11 ` Lukas Wagner [this message]
2026-05-27 14:02 ` applied: [PATCH datacenter-manager 0/6] improve handling of base url and certificate fingerprint for auto-installer gui Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DITHGAKW4EE7.3653FIV8LKNFI@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal