From: Filip Schauer <f.schauer@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager 1/6] server: api: certificates: allow anybody to query the certificate info
Date: Wed, 27 May 2026 16:12:01 +0200 [thread overview]
Message-ID: <170ee830-326c-4d9c-a64a-4cebe5bbe764@proxmox.com> (raw)
In-Reply-To: <20260527125217.260760-2-s.sterz@proxmox.com>
On 27/05/2026 14:52, Shannon Sterz wrote:
> diff --git a/server/src/api/nodes/certificates.rs
> b/server/src/api/nodes/certificates.rs
> index fc12e47..61e6bf9 100644
> --- a/server/src/api/nodes/certificates.rs
> +++ b/server/src/api/nodes/certificates.rs
> @@ -60,7 +60,7 @@ fn get_certificate_info() -> Result<CertificateInfo, Error> {
> },
> },
> access: {
> - permission: &Permission::Privilege(&["system", "certificates"],
> PRIV_SYS_AUDIT, false),
> + permission: &Permission::Anybody,
> },
> returns: {
> type: Array,
PRIV_SYS_AUDIT is now unused:
warning: unused import: `PRIV_SYS_AUDIT`
--> server/src/api/nodes/certificates.rs:16:21
|
16 | use pdm_api_types::{PRIV_SYS_AUDIT, PRIV_SYS_MODIFY};
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by
default
next prev parent reply other threads:[~2026-05-27 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 12:52 [PATCH datacenter-manager 0/6] improve handling of base url and certificate fingerprint for auto-installer gui Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 1/6] server: api: certificates: allow anybody to query the certificate info Shannon Sterz
2026-05-27 14:12 ` Filip Schauer [this message]
2026-05-27 14:16 ` Lukas Wagner
2026-05-27 14:17 ` Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 2/6] pdm-client: add function to query the PDM hosts " Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 3/6] ui: remotes: auto-installer: set pdm_origin() as placeholder not tip Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 4/6] ui: remotes: auto-installer: use pdm_origin() to set initial pdm url Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 5/6] ui: auto-installer: load fingerprint and use it as initial value Shannon Sterz
2026-05-27 12:52 ` [PATCH datacenter-manager 6/6] ui: auto-installer: use info from answer to format preparation command Shannon Sterz
2026-05-27 13:11 ` [PATCH datacenter-manager 0/6] improve handling of base url and certificate fingerprint for auto-installer gui Lukas Wagner
2026-05-27 14:02 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170ee830-326c-4d9c-a64a-4cebe5bbe764@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.