* [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer
@ 2026-05-26 12:40 Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 1/4] ui: auto-installer: use empty string as default fqdn Shannon Sterz
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Shannon Sterz @ 2026-05-26 12:40 UTC (permalink / raw)
To: pdm-devel
this is series of smaller ui & ux fixes for the auto installer ui in
pdm.
Changelog
--------
changes since v2:
* switched from using `*_large_field` to `*_field` to trigger single
column layout in network tab in patch 3 (thanks @ Lukas Wagner)
Shannon Sterz (4):
ui: auto-installer: use empty string as default fqdn
ui: auto-installer: set a default template that users can adapt
ui: auto-installer: make the fqdn field a large field
ui: auto-installer: auto select filter for keyboard layout and
language
.../prepared_answer_add_wizard.rs | 2 +-
.../auto_installer/prepared_answer_form.rs | 18 +++++++++++++-----
2 files changed, 14 insertions(+), 6 deletions(-)
--
2.47.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH datacenter-manager v2 1/4] ui: auto-installer: use empty string as default fqdn
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
@ 2026-05-26 12:40 ` Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 2/4] ui: auto-installer: set a default template that users can adapt Shannon Sterz
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Shannon Sterz @ 2026-05-26 12:40 UTC (permalink / raw)
To: pdm-devel
to avoid users not setting this value themselves, as otherwise
"host.example.com" would be set as default fqdn for an answer file
config. by setting an empty string here, the placeholder is revealed
to users.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
index 01e4000..6ec67d0 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
@@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
target_filter: BTreeMap::new(),
// global options
country: "at".to_owned(),
- fqdn: "host.example.com".to_owned(),
+ fqdn: String::new(),
use_dhcp_fqdn: false,
keyboard: answer::KeyboardLayout::default(),
mailto: String::new(),
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH datacenter-manager v2 2/4] ui: auto-installer: set a default template that users can adapt
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 1/4] ui: auto-installer: use empty string as default fqdn Shannon Sterz
@ 2026-05-26 12:40 ` Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 3/4] ui: auto-installer: make the fqdn field a large field Shannon Sterz
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Shannon Sterz @ 2026-05-26 12:40 UTC (permalink / raw)
To: pdm-devel
instead of just a placeholder that vanishes after someone types a
letter. the default template is special cased as invalid so users need
to adapt it before proceeding.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
.../remotes/auto_installer/prepared_answer_add_wizard.rs | 2 +-
ui/src/remotes/auto_installer/prepared_answer_form.rs | 7 +++++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
index 6ec67d0..d099d5c 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_add_wizard.rs
@@ -55,7 +55,7 @@ impl AddAnswerWizardProperties {
target_filter: BTreeMap::new(),
// global options
country: "at".to_owned(),
- fqdn: String::new(),
+ fqdn: "{{product.product}}{{installation_nr}}.example.com".to_string(),
use_dhcp_fqdn: false,
keyboard: answer::KeyboardLayout::default(),
mailto: String::new(),
diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index 72d2856..6efa66b 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -335,6 +335,13 @@ pub fn render_network_options_form(
.tip(tr!(
"Hostname and domain to set for the target installation. Allows templating."
))
+ .validate(|s: &String| {
+ if s != "{{product.product}}{{installation_nr}}.example.com" {
+ Ok(())
+ } else {
+ Err(anyhow!("Please adapt the default FQDN template!"))
+ }
+ })
.required(!use_dhcp_fqdn),
)
.with_right_field("", DisplayField::new().key("dummy"))
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH datacenter-manager v2 3/4] ui: auto-installer: make the fqdn field a large field
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 1/4] ui: auto-installer: use empty string as default fqdn Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 2/4] ui: auto-installer: set a default template that users can adapt Shannon Sterz
@ 2026-05-26 12:40 ` Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 4/4] ui: auto-installer: auto select filter for keyboard layout and language Shannon Sterz
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Shannon Sterz @ 2026-05-26 12:40 UTC (permalink / raw)
To: pdm-devel
especially with template variables the content of this field can get
fairly long. also moves the "FQDN from DHCP" and "Pin Network
Interfaces" around to match the new layout.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
ui/src/remotes/auto_installer/prepared_answer_form.rs | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index 6efa66b..4610604 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -321,11 +321,11 @@ pub fn render_network_options_form(
.disabled(use_dhcp_network)
.required(!use_dhcp_network),
)
- .with_right_field(
+ .with_field(
tr!("FQDN from DHCP"),
Checkbox::new().name("use-dhcp-fqdn").default(false),
)
- .with_right_field(
+ .with_field(
tr!("Fully-Qualified Domain Name (FQDN)"),
Field::new()
.name("fqdn")
@@ -344,15 +344,14 @@ pub fn render_network_options_form(
})
.required(!use_dhcp_fqdn),
)
- .with_right_field("", DisplayField::new().key("dummy"))
- .with_right_field(
+ .with_field(
tr!("Pin Network Interfaces"),
Checkbox::new()
.name("netif-name-pinning-enabled")
.default(config.netif_name_pinning_enabled),
)
.with_advanced_spacer()
- .with_large_advanced_field(
+ .with_advanced_field(
tr!("Network Device Filters"),
KeyValueList::new()
.value(
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH datacenter-manager v2 4/4] ui: auto-installer: auto select filter for keyboard layout and language
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
` (2 preceding siblings ...)
2026-05-26 12:40 ` [PATCH datacenter-manager v2 3/4] ui: auto-installer: make the fqdn field a large field Shannon Sterz
@ 2026-05-26 12:40 ` Shannon Sterz
2026-05-26 13:19 ` [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Lukas Wagner
2026-05-26 13:47 ` applied: " Thomas Lamprecht
5 siblings, 0 replies; 7+ messages in thread
From: Shannon Sterz @ 2026-05-26 12:40 UTC (permalink / raw)
To: pdm-devel
this should improve the ux of these longer comboboxes.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
ui/src/remotes/auto_installer/prepared_answer_form.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
index 4610604..d932efe 100644
--- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
+++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
@@ -171,6 +171,7 @@ pub fn render_global_options_form(
}
})
.value(config.country.clone())
+ .autoselect_filter(true)
.required(true),
)
.with_field(
@@ -207,6 +208,7 @@ pub fn render_global_options_form(
.into()
})
.value(serde_variant_name(config.keyboard))
+ .autoselect_filter(true)
.required(true),
)
.with_field(
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
` (3 preceding siblings ...)
2026-05-26 12:40 ` [PATCH datacenter-manager v2 4/4] ui: auto-installer: auto select filter for keyboard layout and language Shannon Sterz
@ 2026-05-26 13:19 ` Lukas Wagner
2026-05-26 13:47 ` applied: " Thomas Lamprecht
5 siblings, 0 replies; 7+ messages in thread
From: Lukas Wagner @ 2026-05-26 13:19 UTC (permalink / raw)
To: Shannon Sterz, pdm-devel
On Tue May 26, 2026 at 2:40 PM CEST, Shannon Sterz wrote:
> this is series of smaller ui & ux fixes for the auto installer ui in
> pdm.
>
> Changelog
> --------
>
> changes since v2:
>
> * switched from using `*_large_field` to `*_field` to trigger single
> column layout in network tab in patch 3 (thanks @ Lukas Wagner)
>
> Shannon Sterz (4):
> ui: auto-installer: use empty string as default fqdn
> ui: auto-installer: set a default template that users can adapt
> ui: auto-installer: make the fqdn field a large field
> ui: auto-installer: auto select filter for keyboard layout and
> language
>
> .../prepared_answer_add_wizard.rs | 2 +-
> .../auto_installer/prepared_answer_form.rs | 18 +++++++++++++-----
> 2 files changed, 14 insertions(+), 6 deletions(-)
>
> --
> 2.47.3
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* applied: [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
` (4 preceding siblings ...)
2026-05-26 13:19 ` [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Lukas Wagner
@ 2026-05-26 13:47 ` Thomas Lamprecht
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Lamprecht @ 2026-05-26 13:47 UTC (permalink / raw)
To: pdm-devel, Shannon Sterz
On Tue, 26 May 2026 14:40:09 +0200, Shannon Sterz wrote:
> this is series of smaller ui & ux fixes for the auto installer ui in
> pdm.
>
> Changelog
> --------
>
> changes since v2:
>
> [...]
Applied, thanks!
[1/4] ui: auto-installer: use empty string as default fqdn
commit: c04c76b0b9c8882fc232c579948cb365ee823f5e
[2/4] ui: auto-installer: set a default template that users can adapt
commit: c3a18da6c92efd81ad0ccc615b316a61f2c4a873
[3/4] ui: auto-installer: make the fqdn field a large field
commit: 6a50fad0994aec34d16d3e58d292f12a2251acee
[4/4] ui: auto-installer: auto select filter for keyboard layout and language
commit: 72fc85493eba0364a0c41ad269d8e652271307d8
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-05-26 13:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 12:40 [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 1/4] ui: auto-installer: use empty string as default fqdn Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 2/4] ui: auto-installer: set a default template that users can adapt Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 3/4] ui: auto-installer: make the fqdn field a large field Shannon Sterz
2026-05-26 12:40 ` [PATCH datacenter-manager v2 4/4] ui: auto-installer: auto select filter for keyboard layout and language Shannon Sterz
2026-05-26 13:19 ` [PATCH datacenter-manager v2 0/4] ui & ux improvements for the auto installer Lukas Wagner
2026-05-26 13:47 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.