Re: applied: [PATCH datacenter-manager v3 0/4] add generic, per-remote (and global) cache for remote API responses

["Lukas Wagner" <l.wagner@proxmox.com>]

On Mon May 18, 2026 at 11:53 PM CEST, Thomas Lamprecht wrote:
> On Fri, 15 May 2026 16:49:23 +0200, Lukas Wagner wrote:
>> The main intention is to avoid a sprawl of different caching approaches by
>> establishing a simple, easy to use cache implementation that can be used to
>> persistently cache API responses from remotes (and derived aggregations).
>> 
>> The `namespaced_cache` module is pretty generic and can be moved to proxmox.git
>> (maybe in proxmox-shared-cache) once it has sufficiently stabilized.
>> 
>> [...]
>
> Applied, thanks!
>
> Nice work, and once the dust settles on this we probably can move the core over
> to its own crate in the proxmox workspace, but totally fine to keep it here for
> now.
> Btw. I squashed in small doc typo and some small style nits squashed in, and
> two tiny slightly opinionated code-reuse clean-ups as follow-up, I did not
> think requesting a v4 was worth it for them.

nice cleanup in the remote_updates module! The duplication that you
removed bugged me as well when I wrote it, but couldn't immediately
think of a nice way to remove it and then lost track of it when
preparing the patches.

Thanks!

>
> [1/4] add persistent, generic, namespaced key-value cache implementation
>       commit: cef510ddbf2856414157e2ddb258d54b66c80bb0
> [2/4] add api_cache as a specialized wrapper around the namespaced cache
>       commit: ea30a924f1b9dfc0c3259eb7468dd907c6c8fe09
> [3/4] api: resources: subscriptions: switch over to api_cache
>       commit: 2b1735d601f4ecebe68bcc1d15653b3e2d65598e
> [4/4] remote-updates: switch over to new api_cache
>       commit: 0ae2279c621298dc08118dae70b06e290c7b4bac