From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 561EF1FF141 for ; Tue, 19 May 2026 09:31:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6AC2E32C6C; Tue, 19 May 2026 09:31:01 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 19 May 2026 09:30:57 +0200 Message-Id: Subject: Re: applied: [PATCH datacenter-manager v3 0/4] add generic, per-remote (and global) cache for remote API responses From: "Lukas Wagner" To: "Thomas Lamprecht" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260515144927.427114-1-l.wagner@proxmox.com> <177914118716.151791.7544822894393702702.b4-ty@b4> In-Reply-To: <177914118716.151791.7544822894393702702.b4-ty@b4> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779175844544 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 66QY6TDU7HTGRNEUXIRTK7J2GOGVNOBN X-Message-ID-Hash: 66QY6TDU7HTGRNEUXIRTK7J2GOGVNOBN X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon May 18, 2026 at 11:53 PM CEST, Thomas Lamprecht wrote: > On Fri, 15 May 2026 16:49:23 +0200, Lukas Wagner wrote: >> The main intention is to avoid a sprawl of different caching approaches = by >> establishing a simple, easy to use cache implementation that can be used= to >> persistently cache API responses from remotes (and derived aggregations)= . >>=20 >> The `namespaced_cache` module is pretty generic and can be moved to prox= mox.git >> (maybe in proxmox-shared-cache) once it has sufficiently stabilized. >>=20 >> [...] > > Applied, thanks! > > Nice work, and once the dust settles on this we probably can move the cor= e over > to its own crate in the proxmox workspace, but totally fine to keep it he= re for > now. > Btw. I squashed in small doc typo and some small style nits squashed in, = and > two tiny slightly opinionated code-reuse clean-ups as follow-up, I did no= t > think requesting a v4 was worth it for them. nice cleanup in the remote_updates module! The duplication that you removed bugged me as well when I wrote it, but couldn't immediately think of a nice way to remove it and then lost track of it when preparing the patches. Thanks! > > [1/4] add persistent, generic, namespaced key-value cache implementation > commit: cef510ddbf2856414157e2ddb258d54b66c80bb0 > [2/4] add api_cache as a specialized wrapper around the namespaced cache > commit: ea30a924f1b9dfc0c3259eb7468dd907c6c8fe09 > [3/4] api: resources: subscriptions: switch over to api_cache > commit: 2b1735d601f4ecebe68bcc1d15653b3e2d65598e > [4/4] remote-updates: switch over to new api_cache > commit: 0ae2279c621298dc08118dae70b06e290c7b4bac