Superseded: Re: [PATCH yew-comp/yew-mobile-gui 00/20] firewall tabs and clean up for pve-yew-mobile-gui

["Shannon Sterz" <s.sterz@proxmox.com>]

discovered one more thing, so consider this:

Superseded-by: https://lore.proxmox.com/yew-devel/20260508155722.464564-1-s.sterz@proxmox.com/

On Fri May 8, 2026 at 5:05 PM CEST, Shannon Sterz wrote:
> this series cleans up the pve-yew-mobile-gui a little bit. it does so by first
> fixing a bug in proxmox-yew-comp. then pve-yew-mobile-gui is made clippy clean
> again. the last six patches add, unify and clean up functionality in the gui.
> the main changes are as follows:
>
> * properly populate the rules tab of the existing firewall tabs and comment out
>   empty sub-tabs.
> * add a firewall tab for container guests and nodes
> * two small ui clean ups in how subscription levels and cpu utilization is
>   rendered
>
>
> yew-comp:
>
> Shannon Sterz (1):
>   firewall rules panel: correct the url for the pve cluster firewall
>     rules
>
>  src/configuration/pve/firewall/firewall_rules_panel.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> yew-mobile-gui:
>
> Shannon Sterz (19):
>   cargo.toml: globally ignore certain clippy lints
>   main: avoid unnecessary clones
>   tree-wide: collapse if statements
>   tree-wide: implement the `From` trait instead of the `Into` trait
>   tree-wide: implement `Default` for types with an `new()` constructor
>   tree-wide: remove unnecessary lazy evaluations
>   tree-wide: remove needless borrows
>   configuration page: remove redundant static lifetimes
>   resources/configuration page: remove useless `.into()` calls
>   tree-wide: fix several clippy lints
>   dashboard: use proper plural translation string instead of "CPU(s)"
>   configuration: clarify that "Firewall" shows the cluster's firewall
>   cluster/qemu firewall: use rules panel and comment out unused tabs
>   lxc page: align layout for lxc guest with qemu guests
>   lxc: add support for a rudimentary firewall tab for lxc guests
>   node status: align layout for node status with guest pages
>   node: add a rudimentary firewall tab for cluster nodes
>   api types: remove unused file
>   resources page: map subscription level analogous to dashboard
>
>  Cargo.toml                                    |   5 +
>  src/api_types.rs                              | 131 -------------
>  src/main.rs                                   |  25 ++-
>  src/pages/mod.rs                              |  13 ++
>  src/pages/page_cluster_firewall/mod.rs        |  35 ++--
>  src/pages/page_configuartion.rs               |  22 ++-
>  src/pages/page_dashboard.rs                   |  43 ++---
>  src/pages/page_login.rs                       |  12 +-
>  src/pages/page_lxc_status/dashboard_panel.rs  |  70 ++++---
>  src/pages/page_lxc_status/firewall_panel.rs   | 172 ++++++++++++++++++
>  src/pages/page_lxc_status/mod.rs              |  47 ++++-
>  src/pages/page_lxc_tasks.rs                   |   6 +-
>  src/pages/page_node_status/dashboard_panel.rs |   6 +-
>  src/pages/page_node_status/firewall_panel.rs  | 163 +++++++++++++++++
>  src/pages/page_node_status/mod.rs             |  37 +++-
>  src/pages/page_node_status/services_panel.rs  |   2 +-
>  src/pages/page_node_tasks.rs                  |   6 +-
>  src/pages/page_qemu_status/dashboard_panel.rs |  77 ++++----
>  src/pages/page_qemu_status/firewall_panel.rs  |  33 ++--
>  src/pages/page_qemu_status/mod.rs             |   6 +-
>  src/pages/page_qemu_tasks.rs                  |   6 +-
>  src/pages/page_resources.rs                   |  50 ++---
>  src/pages/page_settings.rs                    |  12 +-
>  src/pages/page_storage_status.rs              |   6 +-
>  src/pages/page_task_status.rs                 |   6 +-
>  src/widgets/guest_backup_panel.rs             |   4 +-
>  src/widgets/task_list_button.rs               |  29 +--
>  src/widgets/tasks_panel.rs                    |   2 +-
>  src/widgets/top_nav_bar.rs                    |  12 +-
>  29 files changed, 671 insertions(+), 367 deletions(-)
>  delete mode 100644 src/api_types.rs
>  create mode 100644 src/pages/page_lxc_status/firewall_panel.rs
>  create mode 100644 src/pages/page_node_status/firewall_panel.rs
>
>
> Summary over all repositories:
>   30 files changed, 672 insertions(+), 368 deletions(-)