From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3DB661FF14F for ; Fri, 08 May 2026 17:59:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1FCE51D912; Fri, 8 May 2026 17:59:10 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 08 May 2026 17:59:02 +0200 To: "Shannon Sterz" , Subject: Superseded: Re: [PATCH yew-comp/yew-mobile-gui 00/20] firewall tabs and clean up for pve-yew-mobile-gui Message-Id: X-Mailer: aerc 0.20.0 References: <20260508150535.420205-1-s.sterz@proxmox.com> In-Reply-To: <20260508150535.420205-1-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778255834199 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GJUQJGFGRSD72M5X4VUWXXRF4PMLZK4B X-Message-ID-Hash: GJUQJGFGRSD72M5X4VUWXXRF4PMLZK4B X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: discovered one more thing, so consider this: Superseded-by: https://lore.proxmox.com/yew-devel/20260508155722.464564-1-s= .sterz@proxmox.com/ On Fri May 8, 2026 at 5:05 PM CEST, Shannon Sterz wrote: > this series cleans up the pve-yew-mobile-gui a little bit. it does so by = first > fixing a bug in proxmox-yew-comp. then pve-yew-mobile-gui is made clippy = clean > again. the last six patches add, unify and clean up functionality in the = gui. > the main changes are as follows: > > * properly populate the rules tab of the existing firewall tabs and comme= nt out > empty sub-tabs. > * add a firewall tab for container guests and nodes > * two small ui clean ups in how subscription levels and cpu utilization i= s > rendered > > > yew-comp: > > Shannon Sterz (1): > firewall rules panel: correct the url for the pve cluster firewall > rules > > src/configuration/pve/firewall/firewall_rules_panel.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > yew-mobile-gui: > > Shannon Sterz (19): > cargo.toml: globally ignore certain clippy lints > main: avoid unnecessary clones > tree-wide: collapse if statements > tree-wide: implement the `From` trait instead of the `Into` trait > tree-wide: implement `Default` for types with an `new()` constructor > tree-wide: remove unnecessary lazy evaluations > tree-wide: remove needless borrows > configuration page: remove redundant static lifetimes > resources/configuration page: remove useless `.into()` calls > tree-wide: fix several clippy lints > dashboard: use proper plural translation string instead of "CPU(s)" > configuration: clarify that "Firewall" shows the cluster's firewall > cluster/qemu firewall: use rules panel and comment out unused tabs > lxc page: align layout for lxc guest with qemu guests > lxc: add support for a rudimentary firewall tab for lxc guests > node status: align layout for node status with guest pages > node: add a rudimentary firewall tab for cluster nodes > api types: remove unused file > resources page: map subscription level analogous to dashboard > > Cargo.toml | 5 + > src/api_types.rs | 131 ------------- > src/main.rs | 25 ++- > src/pages/mod.rs | 13 ++ > src/pages/page_cluster_firewall/mod.rs | 35 ++-- > src/pages/page_configuartion.rs | 22 ++- > src/pages/page_dashboard.rs | 43 ++--- > src/pages/page_login.rs | 12 +- > src/pages/page_lxc_status/dashboard_panel.rs | 70 ++++--- > src/pages/page_lxc_status/firewall_panel.rs | 172 ++++++++++++++++++ > src/pages/page_lxc_status/mod.rs | 47 ++++- > src/pages/page_lxc_tasks.rs | 6 +- > src/pages/page_node_status/dashboard_panel.rs | 6 +- > src/pages/page_node_status/firewall_panel.rs | 163 +++++++++++++++++ > src/pages/page_node_status/mod.rs | 37 +++- > src/pages/page_node_status/services_panel.rs | 2 +- > src/pages/page_node_tasks.rs | 6 +- > src/pages/page_qemu_status/dashboard_panel.rs | 77 ++++---- > src/pages/page_qemu_status/firewall_panel.rs | 33 ++-- > src/pages/page_qemu_status/mod.rs | 6 +- > src/pages/page_qemu_tasks.rs | 6 +- > src/pages/page_resources.rs | 50 ++--- > src/pages/page_settings.rs | 12 +- > src/pages/page_storage_status.rs | 6 +- > src/pages/page_task_status.rs | 6 +- > src/widgets/guest_backup_panel.rs | 4 +- > src/widgets/task_list_button.rs | 29 +-- > src/widgets/tasks_panel.rs | 2 +- > src/widgets/top_nav_bar.rs | 12 +- > 29 files changed, 671 insertions(+), 367 deletions(-) > delete mode 100644 src/api_types.rs > create mode 100644 src/pages/page_lxc_status/firewall_panel.rs > create mode 100644 src/pages/page_node_status/firewall_panel.rs > > > Summary over all repositories: > 30 files changed, 672 insertions(+), 368 deletions(-)