From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH 8/8] subscription: add Reissue Key action with pending-reissue queue
Date: Thu, 07 May 2026 09:50:57 +0200 [thread overview]
Message-ID: <DICA455IGH9M.549L13VAWFD1@proxmox.com> (raw)
In-Reply-To: <20260507072436.2649563-9-t.lamprecht@proxmox.com>
On Thu May 7, 2026 at 9:17 AM CEST, Thomas Lamprecht wrote:
> Wire a new "Reissue Key" action on the Node Subscription Status panel
> (previously titled Node Status) that queues the live subscription on a
> remote node for removal at next Apply Pending. This mirrors how the
> shop describes keys that may be re-bound to a different server ID, so
> the panel uses the same vocabulary end to end.
>
> The pool entry bound to (remote, node) gets a pending-reissue flag.
> Apply Pending issues a DELETE call on the remote and clears the
> binding on success; the entry stays in the pool as a free key. Clear
> Pending only resets the flag and leaves the binding intact, so an
> operator can retry the queueing without losing context.
>
> Foreign-key adoption: when the live node runs a subscription the pool
> has never seen, queueing a reissue imports that key into the pool with
> the flag set. If the operator then runs Clear Pending, the imported
> entry stays in the pool as a free key. This shortcut lets a legacy
> node be brought under PDM management by queueing a reissue and then
> immediately cancelling it, without re-typing the key.
>
> The left-side Key Pool grid renames its action button to "Remove Key"
> for clarity against the new Reissue Key action, and the confirmation
> dialog now warns when the entry is still bound to a remote node so an
> operator does not lose track of the live subscription by mistake.
>
> Note as of now this might be better called "Clear Key", it was split
> out from some work where we can actually actively reissue here.
>
This last commit does not seem to apply cleanly on the latest master,
could you rebase?
Thanks in advance!
next prev parent reply other threads:[~2026-05-07 7:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 7:17 [PATCH 0/8] subscription: add central key pool registry with reissue support Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 1/8] api: subscription cache: ensure max_age=0 forces a fresh fetch Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 2/8] api types: subscription level: render full names Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 3/8] subscription: add key pool data model and config layer Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 4/8] subscription: add key pool and node status API endpoints Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 5/8] ui: add subscription registry with key pool and node status Thomas Lamprecht
2026-05-07 8:15 ` Lukas Wagner
2026-05-07 8:33 ` Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 6/8] cli: add subscription key pool management subcommands Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 7/8] docs: add subscription registry chapter Thomas Lamprecht
2026-05-07 7:17 ` [PATCH 8/8] subscription: add Reissue Key action with pending-reissue queue Thomas Lamprecht
2026-05-07 7:50 ` Lukas Wagner [this message]
2026-05-07 8:38 ` superseded: [PATCH 0/8] subscription: add central key pool registry with reissue support Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DICA455IGH9M.549L13VAWFD1@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.