From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 545CD1FF13F for ; Thu, 07 May 2026 09:51:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A00C8D8DC; Thu, 7 May 2026 09:51:00 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 07 May 2026 09:50:57 +0200 Message-Id: Subject: Re: [PATCH 8/8] subscription: add Reissue Key action with pending-reissue queue From: "Lukas Wagner" To: "Thomas Lamprecht" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260507072436.2649563-1-t.lamprecht@proxmox.com> <20260507072436.2649563-9-t.lamprecht@proxmox.com> In-Reply-To: <20260507072436.2649563-9-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778140149340 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6ZGAOGE7UDTQGRNR4L4WS6HRORG43QJH X-Message-ID-Hash: 6ZGAOGE7UDTQGRNR4L4WS6HRORG43QJH X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu May 7, 2026 at 9:17 AM CEST, Thomas Lamprecht wrote: > Wire a new "Reissue Key" action on the Node Subscription Status panel > (previously titled Node Status) that queues the live subscription on a > remote node for removal at next Apply Pending. This mirrors how the > shop describes keys that may be re-bound to a different server ID, so > the panel uses the same vocabulary end to end. > > The pool entry bound to (remote, node) gets a pending-reissue flag. > Apply Pending issues a DELETE call on the remote and clears the > binding on success; the entry stays in the pool as a free key. Clear > Pending only resets the flag and leaves the binding intact, so an > operator can retry the queueing without losing context. > > Foreign-key adoption: when the live node runs a subscription the pool > has never seen, queueing a reissue imports that key into the pool with > the flag set. If the operator then runs Clear Pending, the imported > entry stays in the pool as a free key. This shortcut lets a legacy > node be brought under PDM management by queueing a reissue and then > immediately cancelling it, without re-typing the key. > > The left-side Key Pool grid renames its action button to "Remove Key" > for clarity against the new Reissue Key action, and the confirmation > dialog now warns when the entry is still bound to a remote node so an > operator does not lose track of the live subscription by mistake. > > Note as of now this might be better called "Clear Key", it was split > out from some work where we can actually actively reissue here. > This last commit does not seem to apply cleanly on the latest master, could you rebase? Thanks in advance!