From: "Daniel Kral" <d.kral@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: applied: [PATCH-SERIES docs/manager v2 00/19] crs docs updates + load balancer ui and docs followup
Date: Tue, 05 May 2026 09:51:04 +0200 [thread overview]
Message-ID: <DIAKV54N4Y9P.N4RLSJBORW33@proxmox.com> (raw)
In-Reply-To: <177790350180.2412829.2493019580410985677.b4-ty@b4>
On Mon May 4, 2026 at 4:05 PM CEST, Thomas Lamprecht wrote:
> On Wed, 15 Apr 2026 11:15:27 +0200, Daniel Kral wrote:
>> changes since v1 (thanks @Shannon, @Michael and @Dominik!):
>> - rebase on master
>> - fix typos and reword some bits as suggested in the review
>>
>> I didn't go for the removal of disabled fields out of UX and consistency
>> and didn't go for adding the pvesh command because of the text flow, see
>> patches #5 and #7 for more information.
>>
>> [...]
>
> Applied, with some wording/grammar fixes squashed in, thanks!
>
> I also added the missing "ha_manager_crs" prefix to three section references,
> as while I'd be fine with having some generic non-ha references now already,
> this still should get some namespace prefix (e.g., just "crs") and we can still
> do that later, when CRS is actually available for non-ha.
Yeah, I was a little pedantic about the existing default permalinks
added to the headings, so existing permalinks aren't broken for those,
but I wonder how many links there exist that point exactly at the
scheduler modes.
I had a read over the adapted patches and the changes look good, thanks!
prev parent reply other threads:[~2026-05-05 7:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 9:15 [PATCH-SERIES docs/manager v2 00/19] crs docs updates + load balancer ui and docs followup Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 01/19] ui: form/CRSOptions: add missing edit modal title Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 02/19] ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 03/19] ui: form/CRSOptions: replace HA service term with HA resource Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 04/19] ui: form/CRSOptions: use view model for auto rebalancing option Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 05/19] ui: form/CRSOptions: allow auto rebalancing only for static and dynamic mode Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 06/19] ha-manager: crs: replace service term with HA resource Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 07/19] ha-manager: crs: remove note about manual changes to datacenter config Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 08/19] ha-manager: crs: improve introduction Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 09/19] ha-manager: crs: introduce crs scheduling mode section Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 10/19] ha-manager: crs: generalize the description for basic and static load modes Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 11/19] ha-manager: crs: remove HA group config from scheduling points list Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 12/19] ha-manager: crs: use impose instead of empose for rules description Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 13/19] ha-manager: crs: use headings for the scheduling points Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 14/19] ha-manager: crs: reword the rebalance on start scheduling point Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 15/19] ha-manager: crs: add more information about rebalance on start in its section Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 16/19] ha-manager: crs: change crs modes to include all active guests Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 17/19] ha-manager: crs: add dynamic load scheduler section Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 18/19] screenshots: update crs datacenter options screenshot Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 19/19] ha-manager: crs: add load balancer section Daniel Kral
2026-05-04 14:05 ` applied: [PATCH-SERIES docs/manager v2 00/19] crs docs updates + load balancer ui and docs followup Thomas Lamprecht
2026-05-05 7:51 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIAKV54N4Y9P.N4RLSJBORW33@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.