From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 05/19] ui: form/CRSOptions: allow auto rebalancing only for static and dynamic mode
Date: Wed, 15 Apr 2026 11:15:32 +0200 [thread overview]
Message-ID: <20260415091635.162224-6-d.kral@proxmox.com> (raw)
In-Reply-To: <20260415091635.162224-1-d.kral@proxmox.com>
The HA auto rebalancing system can only be used with the static and
dynamic load usage information, so constrain the web interface
accordingly.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
---
changes v1 -> v2:
- none
I stuck with not removing the contents from the disabled fields as we're
not really consistent whether we do this, but most of the time let it
stay in the fields. Also user would be rather frustrated if their
previously set values would be removed if they changed the scheduling
mode from 'static'/'dynamic' to 'basic'. Another idea is to always
preserve these values, even though this doesn't clue in the users what
configuration is valid in the end. But let's see what users think.
www/manager6/form/CRSOptions.js | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/www/manager6/form/CRSOptions.js b/www/manager6/form/CRSOptions.js
index 3f3b4fea..3b539fda 100644
--- a/www/manager6/form/CRSOptions.js
+++ b/www/manager6/form/CRSOptions.js
@@ -19,10 +19,14 @@ Ext.define('PVE.form.CRSOptions', {
viewModel: {
data: {
+ crsMode: '__default__',
autoRebalancing: 0,
},
formulas: {
- autoRebalancingDisabled: (get) => !get('autoRebalancing'),
+ canUseAutoRebalancing: (get) =>
+ get('crsMode') === 'static' || get('crsMode') === 'dynamic',
+ autoRebalancingDisabled: (get) =>
+ !get('autoRebalancing') || !get('canUseAutoRebalancing'),
},
},
@@ -42,14 +46,15 @@ Ext.define('PVE.form.CRSOptions', {
name: 'ha',
fieldLabel: gettext('Scheduling Mode'),
deleteEmpty: false,
- value: '__default__',
comboItems: [
['__default__', Proxmox.Utils.defaultText + ' (basic)'],
['basic', gettext('Basic (Resource Count)')],
['static', gettext('Static Load')],
['dynamic', gettext('Dynamic Load')],
],
- defaultValue: '__default__',
+ bind: {
+ value: '{crsMode}',
+ },
},
{
xtype: 'proxmoxcheckbox',
@@ -67,6 +72,7 @@ Ext.define('PVE.form.CRSOptions', {
boxLabel: gettext('Automatically rebalance HA resources'),
bind: {
value: '{autoRebalancing}',
+ disabled: '{!canUseAutoRebalancing}',
},
},
{
--
2.47.3
next prev parent reply other threads:[~2026-04-15 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 9:15 [PATCH-SERIES docs/manager v2 00/19] crs docs updates + load balancer ui and docs followup Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 01/19] ui: form/CRSOptions: add missing edit modal title Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 02/19] ui: form/CRSOptions: rename HA Scheduling to Scheduling Mode Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 03/19] ui: form/CRSOptions: replace HA service term with HA resource Daniel Kral
2026-04-15 9:15 ` [PATCH manager v2 04/19] ui: form/CRSOptions: use view model for auto rebalancing option Daniel Kral
2026-04-15 9:15 ` Daniel Kral [this message]
2026-04-15 9:15 ` [PATCH docs v2 06/19] ha-manager: crs: replace service term with HA resource Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 07/19] ha-manager: crs: remove note about manual changes to datacenter config Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 08/19] ha-manager: crs: improve introduction Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 09/19] ha-manager: crs: introduce crs scheduling mode section Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 10/19] ha-manager: crs: generalize the description for basic and static load modes Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 11/19] ha-manager: crs: remove HA group config from scheduling points list Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 12/19] ha-manager: crs: use impose instead of empose for rules description Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 13/19] ha-manager: crs: use headings for the scheduling points Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 14/19] ha-manager: crs: reword the rebalance on start scheduling point Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 15/19] ha-manager: crs: add more information about rebalance on start in its section Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 16/19] ha-manager: crs: change crs modes to include all active guests Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 17/19] ha-manager: crs: add dynamic load scheduler section Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 18/19] screenshots: update crs datacenter options screenshot Daniel Kral
2026-04-15 9:15 ` [PATCH docs v2 19/19] ha-manager: crs: add load balancer section Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415091635.162224-6-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.