[pve-devel] [PATCH pve-firewall] rename sysctl.d/pve-firewall.conf to 10-pve-firewall.conf

[pve-devel] [PATCH pve-firewall] rename sysctl.d/pve-firewall.conf to 10-pve-firewall.conf

[Alexandre Derumier via pve-devel]

[-- Attachment #1: Type: message/rfc822, Size: 4703 bytes --]

From: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-firewall] rename sysctl.d/pve-firewall.conf to 10-pve-firewall.conf
Date: Mon, 16 Dec 2024 11:36:46 +0100
Message-ID: <20241216103646.3180538-1-alexandre.derumier@groupe-cyllene.com>

Currently, It's not possible to override the values in sysctl.conf
because pve-firewall.conf is exected after.

* Applying /usr/lib/sysctl.d/10-pve-ct-inotify-limits.conf ...
* Applying /usr/lib/sysctl.d/10-pve.conf ...
* Applying /etc/sysctl.d/30-ceph-osd.conf ...
* Applying /usr/lib/sysctl.d/50-pid-max.conf ...
* Applying /usr/lib/sysctl.d/99-protect-links.conf ...
* Applying /etc/sysctl.d/99-sysctl.conf ...
* Applying /usr/lib/sysctl.d/pve-firewall.conf ...
* Applying /etc/sysctl.conf ...

(For evpn with multiple exit nodes, we need to allow asymetric routing
with disabling rp_filter)

reported on the forum:
https://forum.proxmox.com/threads/evpn-vpls-with-multi-exit-nodes-firewall-drop-packet-with-asymetric-routing.158225/#post-729042

Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
---
 src/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/Makefile b/src/Makefile
index aaece5a..06a1da6 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -39,8 +39,7 @@ install: pve-firewall pve-firewall.8 pve-firewall.bash-completion pve-firewall.z
 	install -m 0644 -D pve-firewall.bash-completion $(BASHCOMPLDIR)/pve-firewall
 	install -m 0644 -D pve-firewall.zsh-completion $(ZSHCOMPLDIR)/_pve-firewall
 	install -d -m 0755 $(DESTDIR)/usr/lib/sysctl.d/
-	install -m 0644 pve-firewall-sysctl.conf $(DESTDIR)/usr/lib/sysctl.d/pve-firewall.conf
-
+	install -m 0644 pve-firewall-sysctl.conf $(DESTDIR)/usr/lib/sysctl.d/10-pve-firewall.conf
 .PHONY: clean
 clean: 	
 	make -C PVE clean
-- 
2.39.5



[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-firewall] rename sysctl.d/pve-firewall.conf to 10-pve-firewall.conf

[Robin Christ]

> Currently, It's not possible to override the values in sysctl.conf
> because pve-firewall.conf is exected after.
>
> * Applying /usr/lib/sysctl.d/10-pve-ct-inotify-limits.conf ...
> * Applying /usr/lib/sysctl.d/10-pve.conf ...
> * Applying /etc/sysctl.d/30-ceph-osd.conf ...
> * Applying /usr/lib/sysctl.d/50-pid-max.conf ...
> * Applying /usr/lib/sysctl.d/99-protect-links.conf ...
> * Applying /etc/sysctl.d/99-sysctl.conf ...
> * Applying /usr/lib/sysctl.d/pve-firewall.conf ...
> * Applying /etc/sysctl.conf ...
>
> (For evpn with multiple exit nodes, we need to allow asymetric routing
> with disabling rp_filter)
>
> reported on the forum:
> https://forum.proxmox.com/threads/evpn-vpls-with-multi-exit-nodes-firewall-drop-packet-with-asymetric-routing.158225/#post-729042

Hi,

Could this patch please be reviewed? I just ran into this issue with some special EVPN / BGP setup. Not particularly nice to have an override file named "z-..."

CC @Stefan Hanreich


Cheers,
Robin